You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Brian Candler (JIRA)" <ji...@apache.org> on 2009/11/01 22:07:59 UTC
[jira] Created: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
include_docs=true doesn't honour conflicts=true
-----------------------------------------------
Key: COUCHDB-549
URL: https://issues.apache.org/jira/browse/COUCHDB-549
Project: CouchDB
Issue Type: Improvement
Components: HTTP Interface
Affects Versions: 0.11
Reporter: Brian Candler
Priority: Minor
When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
This feature request could be expanded in a couple of directions:
1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis updated COUCHDB-549:
--------------------------------------
Skill Level: Regular Contributors Level (Easy to Medium)
> include_docs=true doesn't honour conflicts=true
> -----------------------------------------------
>
> Key: COUCHDB-549
> URL: https://issues.apache.org/jira/browse/COUCHDB-549
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 0.11
> Reporter: Brian Candler
> Priority: Minor
> Attachments: couchdb-549-trunk.patch
>
>
> When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
> This feature request could be expanded in a couple of directions:
> 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
> 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
Posted by "Chris Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838618#action_12838618 ]
Chris Anderson commented on COUCHDB-549:
----------------------------------------
this is just a failure to push the conflicts=true parameter through to the include docs code. patches welcome.
> include_docs=true doesn't honour conflicts=true
> -----------------------------------------------
>
> Key: COUCHDB-549
> URL: https://issues.apache.org/jira/browse/COUCHDB-549
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 0.11
> Reporter: Brian Candler
> Priority: Minor
>
> When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
> This feature request could be expanded in a couple of directions:
> 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
> 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-549:
----------------------------------
Attachment: couchdb-549-trunk.patch
Following patch fixes it.
JS test included.
cheers
> include_docs=true doesn't honour conflicts=true
> -----------------------------------------------
>
> Key: COUCHDB-549
> URL: https://issues.apache.org/jira/browse/COUCHDB-549
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 0.11
> Reporter: Brian Candler
> Priority: Minor
> Attachments: couchdb-549-trunk.patch
>
>
> When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
> This feature request could be expanded in a couple of directions:
> 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
> 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
Posted by "Jens Alfke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838614#action_12838614 ]
Jens Alfke commented on COUCHDB-549:
------------------------------------
This actually goes back to 0.10.0.
>From some historical evidence (a unit test in the CouchObjC library that used to work but now breaks) it looks like this changed sometime after 0.8.
Is this considered a bug to be fixed, or just a design limitation?
> include_docs=true doesn't honour conflicts=true
> -----------------------------------------------
>
> Key: COUCHDB-549
> URL: https://issues.apache.org/jira/browse/COUCHDB-549
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 0.11
> Reporter: Brian Candler
> Priority: Minor
>
> When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
> This feature request could be expanded in a couple of directions:
> 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
> 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-549) include_docs=true doesn't honour
conflicts=true
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856425#action_12856425 ]
Filipe Manana commented on COUCHDB-549:
---------------------------------------
Is this ticket still relevant or it's supposed to be abandoned?
> include_docs=true doesn't honour conflicts=true
> -----------------------------------------------
>
> Key: COUCHDB-549
> URL: https://issues.apache.org/jira/browse/COUCHDB-549
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 0.11
> Reporter: Brian Candler
> Priority: Minor
> Attachments: couchdb-549-trunk.patch
>
>
> When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state.
> This feature request could be expanded in a couple of directions:
> 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing.
> 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira