You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by as...@apache.org on 2013/02/11 13:31:52 UTC

svn commit: r1444749 - in /sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post: PostResponseWithErrorHandling.java SlingPostConstants.java

Author: asanso
Date: Mon Feb 11 12:31:52 2013
New Revision: 1444749

URL: http://svn.apache.org/r1444749
Log:
SLING-2156: Provide error handling for POST operations :

- applied patch  from 02/12/11

Added:
    sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/PostResponseWithErrorHandling.java
Modified:
    sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/SlingPostConstants.java

Added: sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/PostResponseWithErrorHandling.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/PostResponseWithErrorHandling.java?rev=1444749&view=auto
==============================================================================
--- sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/PostResponseWithErrorHandling.java (added)
+++ sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/PostResponseWithErrorHandling.java Mon Feb 11 12:31:52 2013
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.servlets.post;
+
+import java.io.IOException;
+import javax.servlet.http.HttpServletResponse;
+import org.apache.felix.scr.annotations.Component;
+import org.apache.felix.scr.annotations.Service;
+import org.apache.sling.api.SlingHttpServletRequest; 
+
+@Component
+@Service
+public class PostResponseWithErrorHandling implements PostResponseCreator{
+
+	public PostResponse createPostResponse(SlingHttpServletRequest request) {
+		if (isSendError(request)) {
+			return new HtmlResponse() {
+
+				@Override
+				protected void doSend(HttpServletResponse response) throws IOException {
+					if (!this.isSuccessful()) {		
+						response.sendError(this.getStatusCode(), this.getError().toString());
+						return;
+					}else{
+						super.doSend(response);
+					}
+				}
+			};
+		}else{
+			return null;
+		}
+	}
+
+	protected boolean isSendError(SlingHttpServletRequest request){
+		boolean sendError=false;
+		String sendErrorParam=request.getParameter(SlingPostConstants.RP_SEND_ERROR);
+		if (sendErrorParam!=null && "true".equalsIgnoreCase(sendErrorParam)){
+			sendError=true;
+		}
+		return sendError;
+	}
+}

Modified: sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/SlingPostConstants.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/SlingPostConstants.java?rev=1444749&r1=1444748&r2=1444749&view=diff
==============================================================================
--- sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/SlingPostConstants.java (original)
+++ sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/SlingPostConstants.java Mon Feb 11 12:31:52 2013
@@ -290,6 +290,14 @@ public interface SlingPostConstants {
      * not set or set to any other value.
      */
     public static final String RP_STATUS = RP_PREFIX + "status";
+    
+	/**
+     * Optional request parameter: defines if to enable the error handling 
+     * also for POST request. 
+     * The parameter value is checked to see if it matches the case-insensitive
+     * value true. 
+     */
+    public static final String RP_SEND_ERROR = RP_PREFIX + "sendError";
 
     /**
      * The supported value for the {@link #RP_STATUS} request parameter