You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/03/22 11:48:00 UTC
[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510433#comment-17510433 ]
ASF subversion and git services commented on WICKET-6965:
---------------------------------------------------------
Commit f333ec0ff16e56756433ff66a4f5ddd12b1a984b in wicket's branch refs/heads/wicket-6944-make-application-listeners-static from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=f333ec0 ]
WICKET-6965 Memory leak in WicketEndpoint
Make WicketEndpoint#REGISTERED_LISTENERS a static field.
Unregister the listener at Application#onBeforeDestroyed()
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
> Memory leak in WicketEndpoint
> -----------------------------
>
> Key: WICKET-6965
> URL: https://issues.apache.org/jira/browse/WICKET-6965
> Project: Wicket
> Issue Type: Bug
> Components: wicket-native-websocket
> Affects Versions: 9.7.0
> Reporter: Thomas Heigl
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Attachments: image-2022-01-10-18-52-42-193.png, image-2022-03-21-16-27-37-798.png
>
>
> Our application OOMed yesterday after about 2-3 weeks of continuous uptime. We normally deploy every other day, so we never noticed this issue before.
> The heap dump identified the possible culprit as {{{}WicketEndpoint$ApplicationListener{}}}:
> !image-2022-01-10-18-52-42-193.png!
> Every new websocket connection registers a new instance of this application listener and after a while we ended up with millions of these listeners:
> {code:java}
> @Override
> public void onOpen(Session session, EndpointConfig endpointConfig)
> {
> String appName = getApplicationName(session);
> WebApplication app = (WebApplication) WebApplication.get(appName);
> app.getApplicationListeners().add(new ApplicationListener(applicationDestroyed));
> try
> {
> ThreadContext.setApplication(app);
> javaxWebSocketProcessor = new JavaxWebSocketProcessor(session, app, endpointConfig);
> }
> finally
> {
> ThreadContext.detach();
> }
> }
> {code}
> Instead of creating a new listener for every connection, the listener should be a singleton.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)