You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Craig (JIRA)" <ji...@apache.org> on 2012/11/09 21:43:12 UTC
[jira] [Created] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Ben Craig created THRIFT-1750:
---------------------------------
Summary: Make compiler build cleanly under visual studio 10
Key: THRIFT-1750
URL: https://issues.apache.org/jira/browse/THRIFT-1750
Project: Thrift
Issue Type: Bug
Components: Compiler (General)
Affects Versions: 0.9, 1.0
Environment: Windows, MSVC10
Reporter: Ben Craig
Fix For: 1.0
Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-1750:
------------------------------
Attachment: compiler_cleanup.patch
Putting a newline at the end of platform.h that was accidentally omitted.
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-1750:
------------------------------
Attachment: compiler_cleanup.patch
Updated to fix MINGW / MSVC PATH_MAX confusion. Tested with mingw compile script.
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494334#comment-13494334 ]
Roger Meier commented on THRIFT-1750:
-------------------------------------
please do not remove MINGW, we need it to cross compile the on linux for windows via contrib/mingw-cross-compile.sh
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-1750:
------------------------------
Attachment: (was: compiler_cleanup.patch)
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494337#comment-13494337 ]
Ben Craig commented on THRIFT-1750:
-----------------------------------
I will look in to making these changes work with that script. It is possible that they already do, but I don't know enough about mingw to be sure.
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-1750:
------------------------------
Attachment: (was: compiler_cleanup.patch)
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-1750:
------------------------------
Attachment: compiler_cleanup.patch
* No more MINGW flags, now testing for built-in _WIN32 and _MSCVER flags
* Now using a config.h (and associated HAVE_CONFIG_H) for the compiler
* No longer using visual studio's "force include" feature
* Tweaked VS project invocation of flex and bison so that it doesn't rely on process current working directory
* Fixing various integer truncation warnings. The scariest of these involves droppint field_ids from 64-bit to 32-bit. They were already being truncated, now the struct is smaller as well.
* Squelching assorted Visual Studio build warnings in the associated files, instead of globally
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under
visual studio 10
Posted by "Ben Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495538#comment-13495538 ]
Ben Craig commented on THRIFT-1750:
-----------------------------------
MINGW still defines _WIN32, so that part seems to be fine. My patch does have one MINGW issue though. Windows uses "MAX_PATH", while *nix usis "PATH_MAX". MINGW takes the *nix approach. I will post an updated patch to address this, after I get an in-house review.
My new patch will be tested against contrib/mingw-cross-compiler.sh before submission.
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
> Key: THRIFT-1750
> URL: https://issues.apache.org/jira/browse/THRIFT-1750
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.9, 1.0
> Environment: Windows, MSVC10
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira