[jira] [Commented] (CASSANDRA-6559) cqlsh should warn about ALLOW FILTERING

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540124#comment-14540124 ] 

Tyler Hobbs commented on CASSANDRA-6559:
----------------------------------------

I apologize for the slow feedback.  There are a couple of issues with this patch.  First, we should be checking {{self.tty}} and only warning when that is true so that we avoid prompting during a {{-f}} invocation.  Second, I would prefer to use cqlsh's parser for detecting the presence of ALLOW FILTERING instead of using {{rindex()}} on the query string directly.

> cqlsh should warn about ALLOW FILTERING
> ---------------------------------------
>
>                 Key: CASSANDRA-6559
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6559
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Tupshin Harper
>            Priority: Minor
>              Labels: cqlsh
>             Fix For: 2.0.x
>
>         Attachments: CASSANDRA-6559.txt
>
>
> ALLOW FILTERING can be a convenience for preliminary exploration of your data, and can be useful for batch jobs, but it is such an anti-pattern for regular production queries, that cqlsh should provie an explicit warn ingwhenever such a query is performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)