You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/07/21 18:29:10 UTC

[GitHub] [tomcat-maven-plugin] liudongmiao opened a new pull request #32: support tomcat 8.5

liudongmiao opened a new pull request #32:
URL: https://github.com/apache/tomcat-maven-plugin/pull/32


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat-maven-plugin] markt-asf commented on a change in pull request #32: support tomcat 8.5

Posted by GitBox <gi...@apache.org>.
markt-asf commented on a change in pull request #32:
URL: https://github.com/apache/tomcat-maven-plugin/pull/32#discussion_r458305303



##########
File path: tomcat8-maven-plugin/pom.xml
##########
@@ -137,12 +137,12 @@
     <dependency>
       <groupId>org.apache.tomcat.embed</groupId>
       <artifactId>tomcat-embed-logging-juli</artifactId>
-      <version>${tomcat8Version}</version>
+      <version>${tomcat8LoggingVersion}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.tomcat.embed</groupId>
       <artifactId>tomcat-embed-logging-log4j</artifactId>
-      <version>${tomcat8Version}</version>
+      <version>${tomcat8LoggingVersion}</version>
     </dependency>
 

Review comment:
       These dependencies should be removed. They are no longer used in 8.5.x




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat-maven-plugin] liudongmiao commented on pull request #32: support tomcat 8.5

Posted by GitBox <gi...@apache.org>.
liudongmiao commented on pull request #32:
URL: https://github.com/apache/tomcat-maven-plugin/pull/32#issuecomment-662209229


   Thanks for review.
   
   However, I cannot make run-its works well, even tomcat7-maven-plugin doesn't work on my devices.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org