You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/11 09:27:10 UTC
[GitHub] [flink] JingsongLi opened a new pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
JingsongLi opened a new pull request #12599:
URL: https://github.com/apache/flink/pull/12599
## What is the purpose of the change
Add filesystem option documentation for Avro
## Verifying this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
}, {
"hash" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"triggerType" : "PUSH"
}, {
"hash" : "b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294)
* 02e4ff3550a67e6fd786a773ffe899456c09be8d UNKNOWN
* b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-643107420
Thanks @wuchong @danny0405 for review, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642530880
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b70cb96566c8e71418a49462ecda2a17b092fd2 (Thu Jun 11 09:30:21 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12599:
URL: https://github.com/apache/flink/pull/12599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
}, {
"hash" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"triggerType" : "PUSH"
}, {
"hash" : "b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3379",
"triggerID" : "b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294)
* 02e4ff3550a67e6fd786a773ffe899456c09be8d UNKNOWN
* b08ebe69a07ca797cb1197bcfe5437f9e3a8e83f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3379)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12599:
URL: https://github.com/apache/flink/pull/12599#issuecomment-642546114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273",
"triggerID" : "8b70cb96566c8e71418a49462ecda2a17b092fd2",
"triggerType" : "PUSH"
}, {
"hash" : "565f1976717740060b743b937906a9dd4100d6ee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294",
"triggerID" : "565f1976717740060b743b937906a9dd4100d6ee",
"triggerType" : "PUSH"
}, {
"hash" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02e4ff3550a67e6fd786a773ffe899456c09be8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b70cb96566c8e71418a49462ecda2a17b092fd2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3273)
* 565f1976717740060b743b937906a9dd4100d6ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3294)
* 02e4ff3550a67e6fd786a773ffe899456c09be8d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12599:
URL: https://github.com/apache/flink/pull/12599#discussion_r439236511
##########
File path: docs/dev/table/connectors/formats/avro.md
##########
@@ -97,6 +97,13 @@ Format Options
<td>String</td>
<td>Specify what format to use, here should be 'avro'.</td>
</tr>
+ <tr>
+ <td><h5>avro.codec</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>For <a href="{{ site.baseurl }}/dev/table/connectors/filesystem.html">Filesystem</a> only, the compression codec for avro. Default no compression. Support deflate, snappy, bzip2, xz.</td>
+ </tr>
Review comment:
No compression as default. The valid enumerations are: `deflate`, `snappy`, `bzip2`, `xz`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12599:
URL: https://github.com/apache/flink/pull/12599#discussion_r439244349
##########
File path: docs/dev/table/connectors/formats/avro.md
##########
@@ -97,6 +97,13 @@ Format Options
<td>String</td>
<td>Specify what format to use, here should be 'avro'.</td>
</tr>
+ <tr>
+ <td><h5>avro.codec</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>For <a href="{{ site.baseurl }}/dev/table/connectors/filesystem.html">Filesystem</a> only, the compression codec for avro. Default no compression. Support deflate, snappy, bzip2, xz.</td>
+ </tr>
Review comment:
Let's use `{% link dev/table/connectors/filesystem.md %}` as the link which is suggested in the dev mailing list recentlly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12599: [FLINK-18253][doc][avro] Add filesystem option documentation for Avro
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12599:
URL: https://github.com/apache/flink/pull/12599#discussion_r438721524
##########
File path: docs/dev/table/connectors/formats/avro.md
##########
@@ -97,6 +97,13 @@ Format Options
<td>String</td>
<td>Specify what format to use, here should be 'avro'.</td>
</tr>
+ <tr>
+ <td><h5>avro.codec</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>For filesystem connector only, the compression codec for avro. Support deflate, snappy, bzip2, xz.</td>
Review comment:
Add a link to 'filesystem connector' and describe the default behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org