You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "alnzng (via GitHub)" <gi...@apache.org> on 2025/09/28 06:52:56 UTC
[I] [Tech Debt] Simplify the vector store setup process [flink-agents]
alnzng opened a new issue, #230:
URL: https://github.com/apache/flink-agents/issues/230
### Search before asking
- [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar.
### Description
**Problem**
The current two-component architecture (Connection + Setup) adds unnecessary complexity for vector stores without clear practical benefits.
Why it works for embedding / chat models:
- One embedding connection → multiple embedding models (e.g. 3-small, 3-large, ada-002)
- Clear separation: auth/limits vs model selection
Why it doesn't fit vector stores:
- Connection and collection are tightly coupled to the same data store
- No clear use case for sharing connections across different setups
- Adds cognitive overhead without meaningful resource sharing
**Proposed Change**
Current (Complex):
```
@vector_store_connection + @vector_store_setup # Two decorators
```
Proposed (Simple):
```
@vector_store # One decorator
def chroma_vector_store():
return ChromaVectorStore, {
"persist_directory": "/data",
"collection": "docs",
"embedding_model": "openai_embedding"
}
```
(This single-component design idea is similar like how we implement `mcp_server` currently)
### Are you willing to submit a PR?
- [x] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Simplify the vector store setup process [flink-agents]
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on issue #230:
URL: https://github.com/apache/flink-agents/issues/230#issuecomment-3343152332
@alnzng,
What is your plan for updating the docs accordingly? Will you do the updates in #221, or in a separate PR? Should I close this issue now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Simplify the vector store setup process [flink-agents]
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong closed issue #230: [Tech Debt] Simplify the vector store setup process
URL: https://github.com/apache/flink-agents/issues/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tech Debt] Simplify the vector store setup process [flink-agents]
Posted by "alnzng (via GitHub)" <gi...@apache.org>.
alnzng commented on issue #230:
URL: https://github.com/apache/flink-agents/issues/230#issuecomment-3344886462
@xintongsong I will update in that PR directly, so you can close this issue now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org