You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 02:32:30 UTC

[GitHub] [flink] WeiZhong94 commented on a change in pull request #11960: [FLINK-12717][python] Support running PyFlink on Windows

WeiZhong94 commented on a change in pull request #11960:
URL: https://github.com/apache/flink/pull/11960#discussion_r421203351



##########
File path: flink-python/src/main/java/org/apache/flink/client/python/PythonGatewayServer.java
##########
@@ -71,15 +75,42 @@ public static void main(String[] args) throws IOException, ExecutionException, I
 		}
 
 		try {
-			// Exit on EOF or broken pipe.  This ensures that the server dies
-			// if its parent program dies.
-			while (System.in.read() != -1) {

Review comment:
       In windows, the `System.in.read()` always returns -1 and returns immediately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org