You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/12 06:58:58 UTC
[GitHub] [ozone] flirmnave opened a new pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
flirmnave opened a new pull request #1694:
URL: https://github.com/apache/ozone/pull/1694
## What changes were proposed in this pull request?
Change close container exception logging to debug level.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3701
## How was this patch tested?
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] flirmnave commented on pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#issuecomment-743949686
Thanks @adoroszlai for suggestions, I have update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1694:
URL: https://github.com/apache/ozone/pull/1694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] flirmnave commented on a change in pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
flirmnave commented on a change in pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#discussion_r546530756
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
##########
@@ -77,8 +78,15 @@ public static ContainerCommandResponseProto logAndReturnError(
ContainerCommandRequestProto request) {
String logInfo = "Operation: {} , Trace ID: {} , Message: {} , " +
"Result: {} , StorageContainerException Occurred.";
- log.info(logInfo, request.getCmdType(), request.getTraceID(),
- ex.getMessage(), ex.getResult().getValueDescriptor().getName(), ex);
+ if (ex.getResult() == CLOSED_CONTAINER_IO) {
Review comment:
Thanks @bshashikant for comment, I have update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] flirmnave commented on pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#issuecomment-750807444
Thank @adoroszlai @ayushtkn @bshashikant for review and comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#issuecomment-743969608
Thanks @flirmnave for updating the patch, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] flirmnave commented on pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#issuecomment-748789076
Thanks for @ayushtkn for comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#discussion_r541584087
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
##########
@@ -77,8 +78,13 @@ public static ContainerCommandResponseProto logAndReturnError(
ContainerCommandRequestProto request) {
String logInfo = "Operation: {} , Trace ID: {} , Message: {} , " +
"Result: {} , StorageContainerException Occurred.";
- log.info(logInfo, request.getCmdType(), request.getTraceID(),
- ex.getMessage(), ex.getResult().getValueDescriptor().getName(), ex);
+ if (ex.getResult() == CLOSED_CONTAINER_IO) {
+ log.debug(logInfo, request.getCmdType(), request.getTraceID(),
+ ex.getMessage(), ex.getResult().getValueDescriptor().getName(), ex);
Review comment:
Nit: Adding `isDebugEnabled()` check would let us avoid some unnecessary operations.
```suggestion
if (log.isDebugEnabled()) {
log.debug(logInfo, request.getCmdType(), request.getTraceID(),
ex.getMessage(), ex.getResult().getValueDescriptor().getName(), ex);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #1694: HDDS-3701. Change Close container exception logging to debug in ContainerUtils#logAndReturnError
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #1694:
URL: https://github.com/apache/ozone/pull/1694#discussion_r546514042
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
##########
@@ -77,8 +78,15 @@ public static ContainerCommandResponseProto logAndReturnError(
ContainerCommandRequestProto request) {
String logInfo = "Operation: {} , Trace ID: {} , Message: {} , " +
"Result: {} , StorageContainerException Occurred.";
- log.info(logInfo, request.getCmdType(), request.getTraceID(),
- ex.getMessage(), ex.getResult().getValueDescriptor().getName(), ex);
+ if (ex.getResult() == CLOSED_CONTAINER_IO) {
Review comment:
Its better to add debug for CONTAINER_NOT_OPEN as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org