You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tsfotis (via GitHub)" <gi...@apache.org> on 2024/09/20 21:14:33 UTC
[PR] refactor(*): remove unneeded async and result on parse_error [opendal]
tsfotis opened a new pull request, #5131:
URL: https://github.com/apache/opendal/pull/5131
# Rationale for this change
- No need for parse_error to be async
- No need to return a Result
# What changes are included in this PR?
removes unneeded async and Result from parse_error()
improve encapsulation of parse_error
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(*): remove unneeded async and result on parse_error [opendal]
Posted by "tsfotis (via GitHub)" <gi...@apache.org>.
tsfotis commented on PR #5131:
URL: https://github.com/apache/opendal/pull/5131#issuecomment-2364648888
@Xuanwo this is the continuation from https://github.com/apache/opendal/pull/5128.
Turns out it was more changes than I thought, sorry for any rebase headaches.
Review and merge when the time is right :+1: .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(*): remove unneeded async and result on parse_error [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5131:
URL: https://github.com/apache/opendal/pull/5131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org