You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/19 08:47:35 UTC

[GitHub] [zookeeper] ztzg commented on pull request #1500: ZOOKEEPER-3561: Generalize target authentication scheme for ZooKeeper authentication enforcement.

ztzg commented on pull request #1500:
URL: https://github.com/apache/zookeeper/pull/1500#issuecomment-711866124


   Hi @arshadmohammad,
   
   > Addressed comments, Added support to configure multiple authentication schemes to enforce authentication
   
   Fantastic; thanks!  (Though I did not mean to imply you had to do the job!)
   
   @hanm wrote:
   > There is one C unit test failure reported by https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1500/4/pipeline
   > 
   > `[2020-10-16T21:54:25.858Z] [exec] /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1500/zookeeper-client/zookeeper-client-c/tests/TestSASLAuth.cc:120: Assertion: assertion failed [Expression: ctx.waitForConnected(zk)]
   >
   > @arshadmohammad do you mind check if that's a flaky test?
   
   Not due to flakiness: the test used to work because the old `sessionRequireClientSASLAuth` flag was able to do its job without having a SASL provider configured (even though the combination makes no sense in practice).  Suggested fix:
   
   ```diff
   --- a/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
   +++ b/zookeeper-client/zookeeper-client-c/tests/zkServer.sh
   @@ -128,9 +128,9 @@ PROPERTIES="$EXTRA_JVM_ARGS -Dzookeeper.extendedTypesEnabled=true -Dznode.contai
    if [ "x$1" == "xstartRequireSASLAuth" ]
    then
        PROPERTIES="-Dzookeeper.sessionRequireClientSASLAuth=true $PROPERTIES"
   +    PROPERTIES="$PROPERTIES -Dzookeeper.authProvider.1=org.apache.zookeeper.server.auth.SASLAuthenticationProvider"
        if [ "x$2" != "x" ]
        then
   -        PROPERTIES="$PROPERTIES -Dzookeeper.authProvider.1=org.apache.zookeeper.server.auth.SASLAuthenticationProvider"
            PROPERTIES="$PROPERTIES -Djava.security.auth.login.config=$2"
        fi
        if [ "x$3" != "x" ]
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org