You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/17 13:39:24 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
cloud-fan opened a new pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Make `size(null)` return null under ANSI mode, regardless of the `spark.sql.legacy.sizeOfNull` config.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In https://github.com/apache/spark/pull/27834, we change the result of `size(null)` to be -1 to match the 2.4 behavior and avoid breaking changes.
However, it's true that the "return -1" behavior is error-prone when being used with aggregate functions. The current ANSI mode controls a bunch of "better behaviors" like failing on overflow. We don't enable these "better behaviors" by default because they are too breaking. The "return null" behavior of `size(null)` is a good fit of the ANSI mode.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No as ANSI mode is off by default.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600320082
+1 for @HeartSaVioR 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600077540
**[Test build #119932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119932/testReport)** for PR 27936 at commit [`a1b68cd`](https://github.com/apache/spark/commit/a1b68cd179eee8bba99cc70cf2f2c2a7f1650188).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600319984
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600078315
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600185482
**[Test build #119941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119941/testReport)** for PR 27936 at commit [`8459d63`](https://github.com/apache/spark/commit/8459d63ddc5f14ef7f91a5d9ebf07a2cdb2090ba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600319987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600319984
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600078315
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600233555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119932/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600232345
**[Test build #119932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119932/testReport)** for PR 27936 at commit [`a1b68cd`](https://github.com/apache/spark/commit/a1b68cd179eee8bba99cc70cf2f2c2a7f1650188).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600357866
Maybe worth to mention here as well - https://github.com/apache/spark/blob/master/docs/sql-ref-ansi-compliance.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600233555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119932/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600361633
Yea, as @HeartSaVioR suggested above, I also think we need to update the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600186246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24664/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600233539
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600306078
Late LGTM. Btw, would it be better to update function javadoc as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600396726
Will open a followup soon, thanks for taking a look!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600078324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24656/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#discussion_r393888568
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3014,7 +3014,10 @@ class SQLConf extends Serializable with Logging {
def csvColumnPruning: Boolean = getConf(SQLConf.CSV_PARSER_COLUMN_PRUNING)
- def legacySizeOfNull: Boolean = getConf(SQLConf.LEGACY_SIZE_OF_NULL)
+ def legacySizeOfNull: Boolean = {
+ // size(null) should return null under ansi mode.
+ getConf(SQLConf.LEGACY_SIZE_OF_NULL) && !getConf(ANSI_ENABLED)
Review comment:
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#discussion_r393815855
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3014,7 +3014,10 @@ class SQLConf extends Serializable with Logging {
def csvColumnPruning: Boolean = getConf(SQLConf.CSV_PARSER_COLUMN_PRUNING)
- def legacySizeOfNull: Boolean = getConf(SQLConf.LEGACY_SIZE_OF_NULL)
+ def legacySizeOfNull: Boolean = {
+ // size(null) should return null under ansi mode.
+ getConf(SQLConf.LEGACY_SIZE_OF_NULL) && !getConf(ANSI_ENABLED)
Review comment:
This is the first one, and I don't think we need a migration guide as the behavior doesn't change by default.
I'll update the config doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600233539
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600186237
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600185482
**[Test build #119941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119941/testReport)** for PR 27936 at commit [`8459d63`](https://github.com/apache/spark/commit/8459d63ddc5f14ef7f91a5d9ebf07a2cdb2090ba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600186246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24664/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600077260
cc @dongjoon-hyun @HeartSaVioR @ssimeonov @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600077540
**[Test build #119932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119932/testReport)** for PR 27936 at commit [`a1b68cd`](https://github.com/apache/spark/commit/a1b68cd179eee8bba99cc70cf2f2c2a7f1650188).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600186237
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27936:
[SPARK-31171][SQL] size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#discussion_r393793315
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3014,7 +3014,10 @@ class SQLConf extends Serializable with Logging {
def csvColumnPruning: Boolean = getConf(SQLConf.CSV_PARSER_COLUMN_PRUNING)
- def legacySizeOfNull: Boolean = getConf(SQLConf.LEGACY_SIZE_OF_NULL)
+ def legacySizeOfNull: Boolean = {
+ // size(null) should return null under ansi mode.
+ getConf(SQLConf.LEGACY_SIZE_OF_NULL) && !getConf(ANSI_ENABLED)
Review comment:
Thanks, `ansi` conf overrides `legacy` conf ? Do we have another `legacy` conf like this? Is it consistent with the other `legacy`? Could you update the migration guide and conf document to be consistent, too?
cc @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600319987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600078324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24656/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27936: [SPARK-31171][SQL]
size(null) should return null under ansi mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#issuecomment-600319376
**[Test build #119941 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119941/testReport)** for PR 27936 at commit [`8459d63`](https://github.com/apache/spark/commit/8459d63ddc5f14ef7f91a5d9ebf07a2cdb2090ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org