You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/09 07:24:12 UTC
[GitHub] [commons-collections] kinow commented on a change in pull request
#126: Improve MapUtils with the null checks,
add JUnit for it and add Javadoc for the parameter indent.
kinow commented on a change in pull request #126: Improve MapUtils with the null checks, add JUnit for it and add Javadoc for the parameter indent.
URL: https://github.com/apache/commons-collections/pull/126#discussion_r364588721
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -159,6 +159,17 @@ public void testInvertMap() {
assertEquals( "3", out.get("C"));
assertEquals( "4", out.get("D"));
assertEquals( "5", out.get("E"));
+
Review comment:
+1, @dota17 other than that this change looks good. If you could update it whenever you have time I think it should be ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services