[GitHub] [iotdb] Cpaulyz commented on a change in pull request #3627: [IOTDB-1517][IOTDB-1521] Refactor TsFile Index for Vector(multi-variable timeseries)

[GitBox <gi...@apache.org>]

Cpaulyz commented on a change in pull request #3627:
URL: https://github.com/apache/iotdb/pull/3627#discussion_r677263387



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/MetadataIndexConstructor.java
##########
@@ -62,49 +68,45 @@ public static MetadataIndexNode constructMetadataIndex(
       MetadataIndexNode currentIndexNode =
           new MetadataIndexNode(MetadataIndexNodeType.LEAF_MEASUREMENT);
       int serializedTimeseriesMetadataNum = 0;
+      String vectorName = ""; // record previous vector name
+      int numOfValueColumns = 0;
       for (int i = 0; i < entry.getValue().size(); i++) {
         timeseriesMetadata = entry.getValue().get(i);
-        if (timeseriesMetadata.isTimeColumn()) {
-          // calculate the number of value columns in this vector
-          int numOfValueColumns = 0;
+        if (numOfValueColumns > 0) {
+          // must be value column
+          numOfValueColumns--;
+          timeseriesMetadata.setMeasurementId(timeseriesMetadata.getMeasurementId());

Review comment:
       useless




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org