You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@livy.apache.org by "RajshekharMuchandi (via GitHub)" <gi...@apache.org> on 2024/01/24 09:01:34 UTC
[PR] [LIVY-977][SERVER][CONF] Livy can not be started if HDFS is still in safe mode [incubator-livy]
RajshekharMuchandi opened a new pull request, #440:
URL: https://github.com/apache/incubator-livy/pull/440
Added safe mode check to implement safe mode
## What changes were proposed in this pull request?
HDFS safe mode is checked when livy session is created. If safe mode is ON, then IllegalStateException is thrown after max retry attempts (configurable) with safe mode interval (configurable) checks are done. If safe mode is OFF, then livy will be able to create session.
https://issues.apache.org/jira/browse/LIVY-977
## How was this patch tested?
Added unit test cases to validate code changes. Also, done manual testing in CDP cluster by creating livy sessions with HDFS safe mode check ON/OFF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LIVY-977][SERVER][CONF] Livy can not be started if HDFS is still in safe mode [incubator-livy]
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal merged PR #440:
URL: https://github.com/apache/incubator-livy/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LIVY-977][SERVER][CONF] Livy can not be started if HDFS is still in safe mode [incubator-livy]
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal commented on PR #440:
URL: https://github.com/apache/incubator-livy/pull/440#issuecomment-1918747185
LGTM, thank you for your contribution @RajshekharMuchandi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LIVY-977][SERVER][CONF] Livy can not be started if HDFS is still in safe mode [incubator-livy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #440:
URL: https://github.com/apache/incubator-livy/pull/440#issuecomment-1908175441
## [Codecov](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `7 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`86fc823`)](https://app.codecov.io/gh/apache/incubator-livy/commit/86fc823893ee96d4effaa4f2b8ef6603cea9d77a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 65.45% compared to head [(`10ee39f`)](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 28.77%.
| [Files](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/livy/server/recovery/FileSystemStateStore.scala](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvcmVjb3ZlcnkvRmlsZVN5c3RlbVN0YXRlU3RvcmUuc2NhbGE=) | 53.33% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #440 +/- ##
=============================================
- Coverage 65.45% 28.77% -36.68%
+ Complexity 954 384 -570
=============================================
Files 103 103
Lines 6084 6102 +18
Branches 922 925 +3
=============================================
- Hits 3982 1756 -2226
- Misses 1546 3987 +2441
+ Partials 556 359 -197
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-livy/pull/440?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org