You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by YehEmily <gi...@git.apache.org> on 2017/08/04 18:17:16 UTC
[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/685
GEODE-3261: Refactoring GfshHelpCommands
[View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3261)
`GfshHelpCommands` has been split into two new command classes, `GfshHelpCommand` and `GfshHintCommand`. One associated test, `HelperIntegrationTest`, has been updated to reflect this change.
**TESTING STATUS: Precheckin in progress**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Commit single and squashed
- [x] `gradlew build` runs cleanly
- [ ] Tests updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #685
----
commit c02976dd103967f9eda3dfb59669bc1096d7dbb8
Author: YehEmily <em...@gmail.com>
Date: 2017-08-04T18:12:50Z
GEODE-3261: Refactoring GfshHelpCommands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
Posted by YehEmily <gi...@git.apache.org>.
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131705221
--- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java ---
@@ -34,7 +36,7 @@
public static void beforeClass() {
helper = new Helper();
// use GfshHelpCommand for testing
- Method[] methods = GfshHelpCommands.class.getMethods();
+ Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --
Good idea - thank you for your feedback! I don't think the original test ever actually tested the hint command, so I wrote two completely new tests: `HelperIntegrationTest.TestHintWithInput` and `HelperIntegrationTest.TestHintWithoutInput`. PR has also been updated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
Posted by pdxrunner <gi...@git.apache.org>.
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131479491
--- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java ---
@@ -34,7 +36,7 @@
public static void beforeClass() {
helper = new Helper();
// use GfshHelpCommand for testing
- Method[] methods = GfshHelpCommands.class.getMethods();
+ Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --
With the original multiple-command class being split, this test now only checks one of the two commands. Add a second test for GfshHintCommand. I would add it to this test class, refactoring the beforeClass functionality into separate imnplementations in each test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---