You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/07/06 14:53:30 UTC
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4270
[FLINK-7110] [client] Add per-job cluster deployment interface
This PR changes the `ClusterDescriptor` interface such that we have a `deploySession` and a `deployJob` call in order to launch a Flink session cluster and a Flink per-job cluster. The latter receives the `JobGraph` which is supposed to be launched in the per-job cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addPerJobDeployment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4270
----
commit 9cfb9718d7b64e253aaf636dc17b8939e2592a98
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-06T07:33:18Z
[FLINK-7110] [client] Add per-job cluster deployment interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4270: [FLINK-7110] [client] Add per-job cluster deployment inte...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4270
Thanks for the review @zentol. I've addressed your comments. Once Travis gives green light, I'll merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4270#discussion_r125942139
--- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java ---
@@ -44,5 +45,12 @@
* @return Client for the cluster
* @throws UnsupportedOperationException if this cluster descriptor doesn't support the operation
*/
- ClientType deploy() throws UnsupportedOperationException;
+ ClientType deploySession() throws UnsupportedOperationException;
--- End diff --
those are good too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4270#discussion_r125935922
--- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java ---
@@ -44,5 +45,12 @@
* @return Client for the cluster
* @throws UnsupportedOperationException if this cluster descriptor doesn't support the operation
*/
- ClientType deploy() throws UnsupportedOperationException;
+ ClientType deploySession() throws UnsupportedOperationException;
--- End diff --
Would it make sense to rename these to `deployForSession` and `deployForJob`? Judgint from the names it seems reasonable to call `deployJob` after `deploySession`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4270#discussion_r125937463
--- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java ---
@@ -44,5 +45,12 @@
* @return Client for the cluster
* @throws UnsupportedOperationException if this cluster descriptor doesn't support the operation
*/
- ClientType deploy() throws UnsupportedOperationException;
+ ClientType deploySession() throws UnsupportedOperationException;
--- End diff --
What about `deploySessionCluster` and `deployJobCluster`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4270#discussion_r125935645
--- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java ---
@@ -44,5 +45,12 @@
* @return Client for the cluster
* @throws UnsupportedOperationException if this cluster descriptor doesn't support the operation
*/
- ClientType deploy() throws UnsupportedOperationException;
+ ClientType deploySession() throws UnsupportedOperationException;
+
+ /**
+ * Deploys a per-job cluster with the given job on the cluster.
+ *
+ * @return Cluster client to talk to the Flink cluster
+ */
+ ClientType deployJob(final JobGraph jobGraph);
--- End diff --
for consistency shouldn't we add `throws UnsupportedOperationException`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4270#discussion_r125937353
--- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java ---
@@ -44,5 +45,12 @@
* @return Client for the cluster
* @throws UnsupportedOperationException if this cluster descriptor doesn't support the operation
*/
- ClientType deploy() throws UnsupportedOperationException;
+ ClientType deploySession() throws UnsupportedOperationException;
+
+ /**
+ * Deploys a per-job cluster with the given job on the cluster.
+ *
+ * @return Cluster client to talk to the Flink cluster
+ */
+ ClientType deployJob(final JobGraph jobGraph);
--- End diff --
I actually think that we should replace the unchecked exception by a checked exception. I will introduce one for this method. Changing the exception of `deploySession` is a follow up, then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---