You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/07 12:19:34 UTC
[GitHub] [trafficserver] AD5GB opened a new pull request #7093: Fix compilation error - missing '&' operator
AD5GB opened a new pull request #7093:
URL: https://github.com/apache/trafficserver/pull/7093
Signed-off-by: Randy DuCharme <ra...@gmail.com>
This corrects the following:
CXX experimental/memcache/tsmemcache_la-tsmemcache.lo
../../trafficserver/plugins/experimental/maxmind_acl/mmdb.cc:280:6: error: out-of-line definition of 'parseregex' does not match any declaration in 'Acl'
Acl::parseregex(const YAML::Node ®ex, bool allow)
^~~~~~~~~~
../../trafficserver/plugins/experimental/maxmind_acl/mmdb.h:106:25: note: type of 1st parameter of member declaration does not match definition ('const YAML::Node' vs 'const YAML::Node &')
void parseregex(const YAML::Node regex, bool allow);
^
1 error generated.
make[2]: *** [Makefile:5823: experimental/maxmind_acl/mmdb.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/randy/Projects/Apache/ats-build/plugins'
make[1]: *** [Makefile:6628: all-recursive] Error 1
make[1]: Leaving directory '/home/randy/Projects/Apache/ats-build/plugins'
make: *** [Makefile:854: all-recursive] Error 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] AD5GB commented on pull request #7093: Fix compilation error - missing '&' operator
Posted by GitBox <gi...@apache.org>.
AD5GB commented on pull request #7093:
URL: https://github.com/apache/trafficserver/pull/7093#issuecomment-670577697
>
>
> @AD5GB Thank you! I broke it with my clang-tidy change. I was about to fix it this morning and thought I should look for open PRs first.
Not a problem. Wasn't sure if I should submit one or not. Was up wayyyyy too early, and bored. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7093: Fix compilation error - missing '&' operator
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7093:
URL: https://github.com/apache/trafficserver/pull/7093#issuecomment-670565418
@AD5GB Thank you! I broke it with my clang-tidy change. I was about to fix it this morning and thought I should look for open PRs first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7093: Fix compilation error - missing '&' operator
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7093:
URL: https://github.com/apache/trafficserver/pull/7093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7093: Fix compilation error - missing '&' operator
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7093:
URL: https://github.com/apache/trafficserver/pull/7093#issuecomment-670539320
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org