[GitHub] [trafficcontrol] mitchell852 opened a new issue #4269: When a ds request is immediately fulfilled, the DS is not updating in TP

[GitBox <gi...@apache.org>]

mitchell852 opened a new issue #4269: When a ds request is immediately fulfilled, the DS is not updating in TP
URL: https://github.com/apache/trafficcontrol/issues/4269
 
 
   ## I'm submitting a ...
   <!-- (check all that apply with "[x]") -->
   <!--- security vulnerability (STOP!! - see above)-->
   - [x] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other <!--(Please do not submit support requests here - see above)-->
   
   ## Traffic Control components affected ...
   <!-- (check all that apply with "[x]") -->
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [x] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   When dsRequests are turned on in traffic_portal_properties.json and a delivery service is updated, a delivery service request is created. However, if the user has the overrideRole (also defined in traffic_portal_properties.json), they can fulfill the delivery service request immediately and immediately apply the delivery service changes.
   
   Fulfilling the delivery service request immediately will:
   
   1. update the underlying delivery service and
   2. fetch the updated delivery service to recreate the ds form
   
   #2 should only happen after #1 is done. That is not happening and therefore #2 is fetching the old ds.
   
   ## Expected / new behavior:
   #2 should only happen after #1 is done. ^^ see above.
   
   ## Minimal reproduction of the problem with instructions:
   - Turn dsRequests on in traffic_portal_properties.json
   - Set the overrideRole in traffic_portal_properties.json (i.e. admin)
   - Login to TP as a user with the overrideRole
   - Update an existing delivery service. For example, change the routing name. 
   - Fulfill the ds request immediately
   - Notice that the routing name did not change in the Delivery Service URL(s) section
   - Refresh the browser. Notice that the routing name has now changed in the Delivery Service URL(s) section.
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp closed issue #4269: When a ds request is immediately fulfilled, the DS is not updating in TP

[GitBox <gi...@apache.org>]

rawlinp closed issue #4269: When a ds request is immediately fulfilled, the DS is not updating in TP
URL: https://github.com/apache/trafficcontrol/issues/4269
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services