You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/02/28 18:46:13 UTC
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/125
GUACAMOLE-225: Bump version numbers to 0.9.12-incubating (guacamole-common unchanged).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client bump-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 3de690abfe54569d2e3adeea36508a51eac9eff1
Author: Michael Jumper <mj...@apache.org>
Date: 2017-02-28T17:33:53Z
GUACAMOLE-225: Bump version numbers to 0.9.12-incubating (guacamole-common unchanged).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103521376
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11 @@
<dependencies>
- <!-- Guacamole Java API -->
- <dependency>
--- End diff --
Similar to apache/incubator-guacamole-manual#23, I removed the explicit dependencies on guacamole-common to rely instead on the transitive dependency pulled via guacamole-ext.
Think that's a bad idea/practice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103522286
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11 @@
<dependencies>
- <!-- Guacamole Java API -->
- <dependency>
--- End diff --
No, makes sense to me - it's just good to have some information on why these are being removed in a PR that's about bumping version numbers. \U0001f603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103524133
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11 @@
<dependencies>
- <!-- Guacamole Java API -->
- <dependency>
--- End diff --
Ah, OK.
I removed them as a part of the version number bump because of the need to check whether those numbers get bumped as well in each case. Normally, I'm an extreme proponent of "include what you use", but guacamole-common in this case is not independently used by the code; it's only used as required to interact with parts of guacamole-ext.
There's some discussion on this here: http://stackoverflow.com/questions/4226756/maven-should-i-keep-or-remove-declared-dependencies-that-are-also-transitives
IMHO: it's not a logical dependency of these extensions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #125: GUACAMOLE-225: Bump version nu...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103519319
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11 @@
<dependencies>
- <!-- Guacamole Java API -->
- <dependency>
--- End diff --
Why are these dependency blocks being removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---