You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/03 05:00:22 UTC

[GitHub] [arrow] cyb70289 commented on pull request #12465: ARROW-15282: [C++][FlightRPC] Split data methods from the underlying transport

cyb70289 commented on pull request #12465:
URL: https://github.com/apache/arrow/pull/12465#issuecomment-1057667955


   I draw a diagram of server related classes based on my understanding.
   https://docs.google.com/spreadsheets/d/12D8psLE1o2NJEMRC4euU1C5r1QhE_7WV4F7TxZA4fwY/edit?usp=sharing
   
   ![flight](https://user-images.githubusercontent.com/4149843/156498509-feaafae9-193c-4fe0-970e-921e774dea1b.png)
   
   A big question is whether it's possible to remove `FlightServiceImpl` and move related code to `FlightServerBase::Impl`?
   
   And some nits:
   
   Can we mark `FlightServiceImpl` class as `final`?
   
   `service_` and `server_` members are not easy to follow throughout the code, what about renaming `FlightServiceImpl::base_` to `server_`, `FlightServerBase::Impl::server_` to `transport_`, `GrpcServerImpl` to `GrpcServerTransportImpl` (maybe member `service_` to `grpc_service`, `server_` to `grpc_server`)?
   
   As `FlightServerBase` and `FligthServiceImpl` can visit each other, does it make sense to remove `GrpcServiceHandler::service_`, leave only `server_`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org