You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashutosh264 (via GitHub)" <gi...@apache.org> on 2026/06/23 13:58:53 UTC
[PR] UI: Show Dag Run conf column by default in Dag Runs list [airflow]
ashutosh264 opened a new pull request, #68904:
URL: https://github.com/apache/airflow/pull/68904
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf in list with compact preview [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4873349857
@pierrejeambrun Thanks for the thorough review!
All suggestions are addressed. Please take another look when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Dag Run conf in list with compact preview [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #68904:
URL: https://github.com/apache/airflow/pull/68904#discussion_r3492289331
##########
airflow-core/newsfragments/68904.improvement.rst:
##########
@@ -0,0 +1 @@
+Show Dag Run conf by default in the Dag Runs list.
Review Comment:
To remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4904905565
Looking better!
1. I think we need to fix our monaco code to show some preview instead of two lines of just `{}`. But that should be a separate PR
2. Good point. In other pages (like xcoms) we have an expand/collapse all code blocks button. Let's add that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4913522989
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Dag Run conf in list with compact preview [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4781757939
**UI Screenshots**
- Empty conf
<img width="1728" height="564" alt="image" src="https://github.com/user-attachments/assets/64651647-dbbd-44c8-8773-bbbdb8373a64" />
- In runs tab
<img width="1728" height="651" alt="image" src="https://github.com/user-attachments/assets/10b4dd98-e172-4634-a149-b17d75bcbc79" />
- On Click
<img width="1546" height="533" alt="image" src="https://github.com/user-attachments/assets/12fc0105-b832-45c4-bcbb-fd164359b286" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4903603626
Thanks for the review.
One follow-up idea I'd like your take on: show conf content expanded by default in the Dag Runs list (i.e. drop collapsed on the conf cell), rather than the folded { ... } preview users have to open row by row. (If I am not wrong, this case is there in AF2)
Motivation: when I'm triaging or comparing runs, I often want to quickly scan or diff conf values across rows (env, batch id, feature flags, etc.). With the column visible but folded, I still have to expand each row manually, which doesn't help much for search/compare workflows.
Trade-off I'm aware of: expanded JSON will make rows taller and the table noisier, especially for large conf objects — which is probably why XCom/Assets use collapsed previews in list views. Conf might be different, though: it's usually smaller and more often the thing you're looking at on this page.
Questions:
Do you think unfolded conf by default is reasonable on Dag Runs, or should we keep collapsed for consistency with other JSON columns?
If it's worth pursuing, I feel it should be tracked as a separate issue.
Happy to prototype and share a screenshot if that would help the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4906371042
Makes sense to add expand/collapse like XCom.
I'm working on a follow-up PR to add expand/collapse-all on the Dag Runs page. I'll tackle the Monaco collapsed preview ({...} instead of a useful preview) in a separate PR after that, as suggested.
Will link the follow-up here once it's up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4913534231
### Backport successfully created: v3-3-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/pull/69604"><img src="https://img.shields.io/badge/PR-69604-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #68904:
URL: https://github.com/apache/airflow/pull/68904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4906702262
Follow-up is up in #69567 - expand/collapse-all on Dag Runs conf, with collapse/expand screenshots. Monaco preview improvement still planned as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Dag Run conf in list with compact preview [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4840774186
> Maybe for performance reason (less monaco IDE mounted at once on the same page)? That still makes the content of the conf available through an extra click, and there are plenty of other tables with monaco columns (xcoms, assets, etc...) that currently work fine. If we want to change this, we probably need to change it for all tables and unless it's proven to be a performance bottleneck (with experiment and metrics) I wouldn't be in favor of going in that direction. Also if we want to explore it, I would create a separate PR because we probably want to discuss more about this and not block the 'display config column by default' part.
Thanks for the review, agreed on keeping Monaco inline for consistency with XCom/Assets/etc.
I've dropped the custom preview/dialog (DagRunConfCell) and reverted to the existing RenderedJsonField collapsed cell. The PR now only makes the Conf column visible by default.
Removed the newsfragment per your comment. Rebased onto the latest main to fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4897215874
Could you update the screenshots please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show Dag Run conf column by default in Dag Runs list [airflow]
Posted by "ashutosh264 (via GitHub)" <gi...@apache.org>.
ashutosh264 commented on PR #68904:
URL: https://github.com/apache/airflow/pull/68904#issuecomment-4903516166
> Could you update the screenshots please?
@bbovenzi I have updated the screenshots, please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org