You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2017/04/19 17:59:06 UTC

Review Request 58538: AMBARI-20780 - Update HBase Configuration group is ignored in upgrade.xml

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58538/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-20780
    https://issues.apache.org/jira/browse/AMBARI-20780


Repository: ambari


Description
-------

The Update HBase Configuration group is ignored in upgrade.xml because it has an invalid syntax. It should be of xsi:type="cluster" because it contains an execute-stage.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 3757121 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7fd175 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 78fe831 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0dd7f58 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml 4d4d972 


Diff: https://reviews.apache.org/r/58538/diff/1/


Testing
-------

mvn clean test


Thanks,

Tim Thorpe


Re: Review Request 58538: AMBARI-20780 - Update HBase Configuration group is ignored in upgrade.xml

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58538/#review172378
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On April 19, 2017, 5:59 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58538/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20780
>     https://issues.apache.org/jira/browse/AMBARI-20780
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Update HBase Configuration group is ignored in upgrade.xml because it has an invalid syntax. It should be of xsi:type="cluster" because it contains an execute-stage.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 3757121 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7fd175 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 78fe831 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0dd7f58 
>   ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml 4d4d972 
> 
> 
> Diff: https://reviews.apache.org/r/58538/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>


Re: Review Request 58538: AMBARI-20780 - Update HBase Configuration group is ignored in upgrade.xml

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58538/#review172379
-----------------------------------------------------------


Ship it!




Good find!

- Alejandro Fernandez


On April 19, 2017, 5:59 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58538/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20780
>     https://issues.apache.org/jira/browse/AMBARI-20780
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Update HBase Configuration group is ignored in upgrade.xml because it has an invalid syntax. It should be of xsi:type="cluster" because it contains an execute-stage.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 3757121 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7fd175 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 78fe831 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0dd7f58 
>   ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml 4d4d972 
> 
> 
> Diff: https://reviews.apache.org/r/58538/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>