You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/04/05 22:06:39 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #362: [Phoenix-4841] Filters that uses RVC with pk columns where with DESC sort order don't work correctly

swaroopak commented on a change in pull request #362: [Phoenix-4841] Filters that uses RVC with pk columns where with DESC sort order don't work correctly
URL: https://github.com/apache/phoenix/pull/362#discussion_r272757528
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
 ##########
 @@ -22,14 +22,18 @@
 import java.io.IOException;
 import java.math.BigDecimal;
 import java.sql.SQLException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 
+import com.google.common.collect.ImmutableList;
 
 Review comment:
   Do we really need this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services