You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:33:23 UTC

[GitHub] [pulsar] momo-jun commented on a change in pull request #13758: [DO NOT MERGE][Doc] Rename two parameters about metadatastore (ZK free) and add a comprehensive list for deprecated parameters of broker

momo-jun commented on a change in pull request #13758:
URL: https://github.com/apache/pulsar/pull/13758#discussion_r791309091



##########
File path: site2/docs/administration-proxy.md
##########
@@ -14,8 +14,8 @@ Before using the proxy, you need to configure it with the brokers addresses in t
 
 Pulsar uses [ZooKeeper](https://zookeeper.apache.org) for service discovery. To connect the proxy to ZooKeeper, specify the following in `conf/proxy.conf`.
 ```properties
-zookeeperServers=zk-0,zk-1,zk-2
-configurationStoreServers=zk-0:2184,zk-remote:2184
+metadataStoreUrl=my-zk-0:2181,my-zk-1:2181,my-zk-2:2181
+configurationMetadataStoreUrl=my-zk-0:2184,my-zk-remote:2184

Review comment:
       > Once #13777 will be merged to master, you can ignore this review.
   
   Agree. Thanks for pointing this out.
   
   

##########
File path: site2/docs/functions-runtime.md
##########
@@ -270,7 +270,7 @@ For example, if you use token authentication, you need to configure the followin
 ```Yaml
 clientAuthenticationPlugin: org.apache.pulsar.client.impl.auth.AuthenticationToken
 clientAuthenticationParameters: file:///etc/pulsar/token/admin-token.txt
-configurationStoreServers: zookeeper-cluster:2181 # auth requires a connection to zookeeper

Review comment:
       > Once #13782 will be merged to master, you can ignore this review.
   
   Agree. Thanks for pointing this out.

##########
File path: site2/docs/functions-worker.md
##########
@@ -199,12 +199,12 @@ properties:
 
 ##### Enable Authorization Provider
 
-To enable authorization on Functions Worker, you need to configure `authorizationEnabled`, `authorizationProvider` and `configurationStoreServers`. The authentication provider connects to `configurationStoreServers` to receive namespace policies.
+To enable authorization on Functions Worker, you need to configure `authorizationEnabled`, `authorizationProvider` and `configurationMetadataStoreUrl`. The authentication provider connects to `configurationMetadataStoreUrl` to receive namespace policies.
 
 ```yaml
 authorizationEnabled: true
 authorizationProvider: org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider
-configurationStoreServers: <configuration-store-servers>
+configurationMetadataStoreUrl: <configuration-store-servers>

Review comment:
       > Once #13782 will be merged to master, you can ignore this review.
   
   Agree. Thanks for pointing this out.

##########
File path: site2/docs/reference-configuration.md
##########
@@ -695,8 +707,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
 |Name|Description|Default|

Review comment:
       > Once #13777 will be merged to master, you can ignore this review.
   
   Agree. Thanks for pointing this out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org