You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/06/19 01:07:56 UTC

Review Request 60177: ATLAS-1866: DSL 'like' operator fails for associated entity attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60177/
-----------------------------------------------------------

Review request for atlas, Sarath Subramanian and Suma Shivaprasad.


Bugs: ATLAS-1866
    https://issues.apache.org/jira/browse/ATLAS-1866


Repository: atlas


Description
-------

Updated DSL translator to handle attributes of associated entities in filter expressions


Diffs
-----

  repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 5f8bb800 
  repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java aaec6fe1 
  repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 675ab8ab 


Diff: https://reviews.apache.org/r/60177/diff/1/


Testing
-------

added test cases to cover attributes of associated entities


Thanks,

Madhan Neethiraj


Re: Review Request 60177: ATLAS-1866: DSL 'like' operator fails for associated entity attributes

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60177/#review178169
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On June 18, 2017, 6:07 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60177/
> -----------------------------------------------------------
> 
> (Updated June 18, 2017, 6:07 p.m.)
> 
> 
> Review request for atlas, Sarath Subramanian and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1866
>     https://issues.apache.org/jira/browse/ATLAS-1866
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated DSL translator to handle attributes of associated entities in filter expressions
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 5f8bb800 
>   repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java aaec6fe1 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 675ab8ab 
> 
> 
> Diff: https://reviews.apache.org/r/60177/diff/1/
> 
> 
> Testing
> -------
> 
> added test cases to cover attributes of associated entities
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>