You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/01 00:48:59 UTC
[GitHub] [calcite] laurentgo opened a new pull request #1954: [CALCITE-3965] Avoid DiffRepository lock contention
laurentgo opened a new pull request #1954:
URL: https://github.com/apache/calcite/pull/1954
When many test cases using the same DiffRepository instances are running
on multiple threads, it causes lots of contention because all methods
are synchronized. One of the most used method is
DiffRepository#expand(String, String) which do not alter the state of
the tree in most cases.
As the method content itself is thread-safe, remove the synchronized
keyword as it does not bring any extra safety and just increase
artificially the contention around the lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] laurentgo commented on pull request #1954: [CALCITE-3965] Avoid DiffRepository lock contention
Posted by GitBox <gi...@apache.org>.
laurentgo commented on pull request #1954:
URL: https://github.com/apache/calcite/pull/1954#issuecomment-625010530
Per JIRA comment, merging the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org