[allura] branch gc/8414 updated: fixup! 8414 Added a new validator to restrict private/internal ips from being submitted in the form

[gc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gcruz pushed a commit to branch gc/8414
in repository https://gitbox.apache.org/repos/asf/allura.git


The following commit(s) were added to refs/heads/gc/8414 by this push:
     new e4840b8  fixup! 8414 Added a new validator to restrict private/internal ips from being submitted in the form
e4840b8 is described below

commit e4840b84b560ddf502fce2897e6e9f344586ff73
Author: Guillermo Cruz <gu...@slashdotmedia.com>
AuthorDate: Fri Feb 25 10:17:43 2022 -0700

    fixup! 8414 Added a new validator to restrict private/internal ips from being submitted in the form
---
 ForgeSVN/forgesvn/tests/functional/test_controllers.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ForgeSVN/forgesvn/tests/functional/test_controllers.py b/ForgeSVN/forgesvn/tests/functional/test_controllers.py
index 6ea2059..f32be68 100644
--- a/ForgeSVN/forgesvn/tests/functional/test_controllers.py
+++ b/ForgeSVN/forgesvn/tests/functional/test_controllers.py
@@ -320,7 +320,6 @@ class TestImportController(SVNTestController):
 
     @with_tool('test', 'SVN', 'empty', 'empty SVN')
     def test_url_import_validation_fail(self):
-        #r = self.app.get('/p/test/admin/empty/importer').follow(status=200)
         params = dict(checkout_url='https://sf-1.xb.sf.net/trac/url')
         r = self.app.post('/p/test/admin/empty/importer/do_import', params,
                           status=200)
@@ -331,7 +330,7 @@ class TestImportController(SVNTestController):
     def test_do_import_empty_repo(self, tasks):
         self.app.post('/p/test/admin/empty/importer/do_import',
                       {'checkout_url': 'http://fake.svn/'})
-        assert tasks.reclone.post.called
+        assert not tasks.reclone.post.called
 
     @patch('forgesvn.svn_main.allura.tasks.repo_tasks')
     @with_tool('test', 'SVN', 'empty', 'empty SVN')