You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/04/24 17:36:13 UTC

Review Request 58675: Unable to proceed from manual prompt in EU wizard due to IllegalArgumentException

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58675/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, DmitruielincYR DmitruielincYR, and Jonathan Hurley.


Bugs: AMBARI-20835
    https://issues.apache.org/jira/browse/AMBARI-20835


Repository: ambari


Description
-------

The association was not being made of HRC to the Stage when creating the entities.

I also slipped in an NPE that was found in a config action.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 8c4eae89e7 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java fbb88d8e4b 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java e12461ddb3 


Diff: https://reviews.apache.org/r/58675/diff/1/


Testing
-------

Manual.  Automated pending.


Thanks,

Nate Cole


Re: Review Request 58675: Unable to proceed from manual prompt in EU wizard due to IllegalArgumentException

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58675/#review172855
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On April 24, 2017, 8:46 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58675/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 8:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DmitruielincYR DmitruielincYR, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20835
>     https://issues.apache.org/jira/browse/AMBARI-20835
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The association was not being made of HRC to the Stage when creating the entities.
> 
> I also slipped in an NPE that was found in a config action.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 8c4eae89e7 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 6b345758ea 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java fbb88d8e4b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 2bc1e6834b 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java e12461ddb3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58675/diff/2/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:03 min
> [INFO] Finished at: 2017-04-24T16:30:55-04:00
> [INFO] Final Memory: 64M/684M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 58675: Unable to proceed from manual prompt in EU wizard due to IllegalArgumentException

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58675/
-----------------------------------------------------------

(Updated April 24, 2017, 4:46 p.m.)


Review request for Ambari, Alejandro Fernandez, DmitruielincYR DmitruielincYR, and Jonathan Hurley.


Bugs: AMBARI-20835
    https://issues.apache.org/jira/browse/AMBARI-20835


Repository: ambari


Description
-------

The association was not being made of HRC to the Stage when creating the entities.

I also slipped in an NPE that was found in a config action.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 8c4eae89e7 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 6b345758ea 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java fbb88d8e4b 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 2bc1e6834b 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java e12461ddb3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 


Diff: https://reviews.apache.org/r/58675/diff/2/

Changes: https://reviews.apache.org/r/58675/diff/1-2/


Testing (updated)
-------

Manual.  Automated:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:03 min
[INFO] Finished at: 2017-04-24T16:30:55-04:00
[INFO] Final Memory: 64M/684M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 58675: Unable to proceed from manual prompt in EU wizard due to IllegalArgumentException

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58675/#review172824
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On April 24, 2017, 1:36 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58675/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DmitruielincYR DmitruielincYR, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20835
>     https://issues.apache.org/jira/browse/AMBARI-20835
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The association was not being made of HRC to the Stage when creating the entities.
> 
> I also slipped in an NPE that was found in a config action.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 8c4eae89e7 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java fbb88d8e4b 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java e12461ddb3 
> 
> 
> Diff: https://reviews.apache.org/r/58675/diff/1/
> 
> 
> Testing
> -------
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>