[GitHub] [iceberg] dhruv-pratap commented on a diff in pull request #5690: Python: Add CLI command to list files

[GitBox <gi...@apache.org>]

dhruv-pratap commented on code in PR #5690:
URL: https://github.com/apache/iceberg/pull/5690#discussion_r967158430


##########
python/pyiceberg/table/snapshots.py:
##########
@@ -103,6 +110,12 @@ def __str__(self) -> str:
         result_str = f"{operation}id={self.snapshot_id}{parent_id}{schema_id}"
         return result_str
 
+    def fetch_manifest_list(self, io: FileIO) -> List[ManifestFile]:

Review Comment:
   Minor: Should we add tests for this function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org