You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/22 07:55:44 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3502: [Enhancement] Some optimization of the code.[SubscribeTask]

Alonexc opened a new issue, #3502:
URL: https://github.com/apache/incubator-eventmesh/issues/3502

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/226833270-0dc6fbc7-806d-4a5c-af36-363e75db685b.png)
   located at:
   eventmesh-storage/eventmesh-storage-pravega/src/main/java/org/apache/eventmesh/storage/pravega/client/SubscribeTask.java line 50
   analysis and explanation:
   a. common part can be extracted removing branch
   b. reduce the total number of continue statements in this loop to use at most one.
   
   
   ### Describe the solution you'd like
   
   ![image](https://user-images.githubusercontent.com/91315508/226833327-6b6bfe23-a434-4b73-a1d5-8982b121f2e9.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] harshithasudhakar commented on issue #3502: [Enhancement] Some optimization of the code.[SubscribeTask]

Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on issue #3502:
URL: https://github.com/apache/eventmesh/issues/3502#issuecomment-1501036725

   I'd like to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] weihubeats closed issue #3502: [Enhancement] Some optimization of the code.[SubscribeTask]

Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats closed issue #3502: [Enhancement] Some optimization of the code.[SubscribeTask]
URL: https://github.com/apache/eventmesh/issues/3502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] Alonexc commented on issue #3502: [Enhancement] Some optimization of the code.[SubscribeTask]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3502:
URL: https://github.com/apache/eventmesh/issues/3502#issuecomment-1501513682

   You are very welcome to pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org