You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/16 01:32:31 UTC

[GitHub] gigasquid opened a new pull request #12196: Adding Clojure Tests to Increase Coverage

gigasquid opened a new pull request #12196: Adding Clojure Tests to Increase Coverage
URL: https://github.com/apache/incubator-mxnet/pull/12196
 
 
   ## Description ##
   This adds to the Clojure unit tests to increase coverage
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Unit tests have been added 
   - Text change to Visualization README
   
   ## Comments ##
   
   Old cloverage results:
   
   ```
   |-----------------------------------------+---------+---------|
   |                               Namespace | % Forms | % Lines |
   |-----------------------------------------+---------+---------|
   |                           dev.generator |   93.07 |   94.33 |
   |           org.apache.clojure-mxnet.base |  100.00 |  100.00 |
   |       org.apache.clojure-mxnet.callback |  100.00 |  100.00 |
   |        org.apache.clojure-mxnet.context |   76.00 |   85.71 |
   |          org.apache.clojure-mxnet.dtype |  100.00 |  100.00 |
   |    org.apache.clojure-mxnet.eval-metric |   95.00 |  100.00 |
   |       org.apache.clojure-mxnet.executor |   89.66 |   95.00 |
   |    org.apache.clojure-mxnet.initializer |   25.00 |   43.75 |
   |             org.apache.clojure-mxnet.io |   71.71 |   80.00 |
   |        org.apache.clojure-mxnet.kvstore |   82.91 |   76.00 |
   | org.apache.clojure-mxnet.kvstore-server |   58.73 |   50.00 |
   |   org.apache.clojure-mxnet.lr-scheduler |   22.22 |   66.67 |
   |         org.apache.clojure-mxnet.module |   74.99 |   88.62 |
   |        org.apache.clojure-mxnet.monitor |  100.00 |  100.00 |
   |        org.apache.clojure-mxnet.ndarray |   90.86 |   91.38 |
   |      org.apache.clojure-mxnet.optimizer |   91.21 |   88.24 |
   |       org.apache.clojure-mxnet.profiler |   20.00 |   40.00 |
   |         org.apache.clojure-mxnet.random |  100.00 |  100.00 |
   |          org.apache.clojure-mxnet.shape |   94.44 |   90.00 |
   |         org.apache.clojure-mxnet.symbol |   48.87 |   54.62 |
   |           org.apache.clojure-mxnet.util |   98.86 |   99.16 |
   |  org.apache.clojure-mxnet.visualization |    6.82 |   20.00 |
   |-----------------------------------------+---------+---------|
   |                               ALL FILES |   80.01 |   84.14 |
   |-----------------------------------------+---------+---------|
   ```
   
   
   New cloverage results:
   
   ```
   |-----------------------------------------+---------+---------|
   |                               Namespace | % Forms | % Lines |
   |-----------------------------------------+---------+---------|
   |                           dev.generator |   99.19 |  100.00 |
   |           org.apache.clojure-mxnet.base |  100.00 |  100.00 |
   |       org.apache.clojure-mxnet.callback |  100.00 |  100.00 |
   |        org.apache.clojure-mxnet.context |   76.00 |   85.71 |
   |          org.apache.clojure-mxnet.dtype |  100.00 |  100.00 |
   |    org.apache.clojure-mxnet.eval-metric |   95.00 |  100.00 |
   |       org.apache.clojure-mxnet.executor |   89.66 |   95.00 |
   |    org.apache.clojure-mxnet.initializer |  100.00 |  100.00 |
   |             org.apache.clojure-mxnet.io |   71.71 |   80.00 |
   |        org.apache.clojure-mxnet.kvstore |   82.91 |   76.00 |
   | org.apache.clojure-mxnet.kvstore-server |   58.73 |   50.00 |
   |   org.apache.clojure-mxnet.lr-scheduler |  100.00 |  100.00 |
   |         org.apache.clojure-mxnet.module |   75.30 |   89.00 |
   |        org.apache.clojure-mxnet.monitor |  100.00 |  100.00 |
   |        org.apache.clojure-mxnet.ndarray |   90.86 |   91.38 |
   |      org.apache.clojure-mxnet.optimizer |   91.21 |   88.24 |
   |       org.apache.clojure-mxnet.profiler |   85.00 |   90.00 |
   |         org.apache.clojure-mxnet.random |  100.00 |  100.00 |
   |          org.apache.clojure-mxnet.shape |   94.44 |   90.00 |
   |         org.apache.clojure-mxnet.symbol |   51.13 |   57.14 |
   |           org.apache.clojure-mxnet.util |   98.86 |   99.16 |
   |  org.apache.clojure-mxnet.visualization |   54.55 |   73.33 |
   |-----------------------------------------+---------+---------|
   |                               ALL FILES |   82.50 |   87.26 |
   |-----------------------------------------+---------+---------|
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services