You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/04 03:58:41 UTC

[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1287: HDDS-4059: SCMStateMachine::applyTransaction() should not invoke TransactionContext.getClientRequest()

GlenGeng opened a new pull request #1287:
URL: https://github.com/apache/hadoop-ozone/pull/1287


   ## What changes were proposed in this pull request?
   
   `applyTransaction()` should not call `trx.getClientRequest()`, since client request will not be replicated from leader to follower. 
   
   We should call `trx.getStateMachineLogEntry()`, since content of client request will be injected to `StateMachineEntryProto` at leader, and extracted from log entry at follower.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4059
   
   ## How was this patch tested?
   
   CI
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] timmylicheng merged pull request #1287: HDDS-4059: SCMStateMachine::applyTransaction() should not invoke TransactionContext.getClientRequest()

Posted by GitBox <gi...@apache.org>.
timmylicheng merged pull request #1287:
URL: https://github.com/apache/hadoop-ozone/pull/1287


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] timmylicheng commented on pull request #1287: HDDS-4059: SCMStateMachine::applyTransaction() should not invoke TransactionContext.getClientRequest()

Posted by GitBox <gi...@apache.org>.
timmylicheng commented on pull request #1287:
URL: https://github.com/apache/hadoop-ozone/pull/1287#issuecomment-671200151


   +1. Thanks for @GlenGeng contribution. Will merge soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org