[GitHub] [incubator-superset] agatapst edited a comment on pull request #11876: fix: Check if annotation type is supported by the given chart type

[GitBox <gi...@apache.org>]

agatapst edited a comment on pull request #11876:
URL: https://github.com/apache/incubator-superset/pull/11876#issuecomment-736663326


   @adam-stasiak thanks for your thorough test! 🙂 You are right, for dual line chart I can also see this error. However, it occurs also on the master branch. I have checked this problem and I think you had discovered another bug - which is indirectly connected with the bug described above. 
   
   In some charts, which according to `superset-ui` do not have any supported annotation types, it is possible to add one - at least try to do that, because it does not work. For example dual line chart - in the left bar, _Add Annotation Layer_ button should be hidden. Bar chart does not have any supported annotation types and this section is hidden - it works fine in that case. The problem may be that in some cases, it is not properly checked and the section is shown for incorrect charts. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org