You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/05/08 06:59:03 UTC

[GitHub] spark pull request #20405: [SPARK-23229][SQL] Dataset.hint should use planWi...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20405#discussion_r186632978
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -1216,7 +1216,7 @@ class Dataset[T] private[sql](
        */
       @scala.annotation.varargs
       def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
    -    UnresolvedHint(name, parameters, logicalPlan)
    +    UnresolvedHint(name, parameters, planWithBarrier)
    --- End diff --
    
    shall we go with this workaround?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org