You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org> on 2006/12/18 21:01:20 UTC

[jira] Created: (TAPESTRY-1198) problem with Checkbox + custom validators

problem with Checkbox + custom validators
-----------------------------------------

                 Key: TAPESTRY-1198
                 URL: http://issues.apache.org/jira/browse/TAPESTRY-1198
             Project: Tapestry
          Issue Type: Bug
          Components: Framework
    Affects Versions: 4.1.1
            Reporter: Norbert Sándor


I have a Checkbox component which has a custom validator. The validator requires the checkbox to be in checked state under certain circumstances.

My problem is the following:
1. the checkbox is checked
2. the user unchecks it and submits the form
3. after the resulting page is rendered, the validation message is rendered as expected BUT the checkbox will be checked!

The cause of the problem is that Checkbox doesn't record the newly submitted value in the validation delegate.
For example TextField does this task indirectly by calling TranslatedFieldSupport.parse(), and the recorded value is read indirectly by TranslatedFieldSupport.format().

Proposed solution: call the delegate's getFieldInputValue() and recordFieldInputValue() methods.

Regards:
Norbi

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

[jira] Updated: (TAPESTRY-1198) problem with Checkbox + custom validators

Posted by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-1198?page=all ]

Norbert Sándor updated TAPESTRY-1198:
-------------------------------------

    Attachment: Checkbox.patch

patch of my implementation

> problem with Checkbox + custom validators
> -----------------------------------------
>
>                 Key: TAPESTRY-1198
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-1198
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.1.1
>            Reporter: Norbert Sándor
>         Attachments: Checkbox.patch
>
>
> I have a Checkbox component which has a custom validator. The validator requires the checkbox to be in checked state under certain circumstances.
> My problem is the following:
> 1. the checkbox is checked
> 2. the user unchecks it and submits the form
> 3. after the resulting page is rendered, the validation message is rendered as expected BUT the checkbox will be checked!
> The cause of the problem is that Checkbox doesn't record the newly submitted value in the validation delegate.
> For example TextField does this task indirectly by calling TranslatedFieldSupport.parse(), and the recorded value is read indirectly by TranslatedFieldSupport.format().
> Proposed solution: call the delegate's getFieldInputValue() and recordFieldInputValue() methods.
> Regards:
> Norbi

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

[jira] Resolved: (TAPESTRY-1198) problem with Checkbox + custom validators

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-1198?page=all ]

Jesse Kuhnert resolved TAPESTRY-1198.
-------------------------------------

    Fix Version/s: 4.1.2
       Resolution: Fixed
         Assignee: Jesse Kuhnert

Applied. (though it was done slightly differently ) 

> problem with Checkbox + custom validators
> -----------------------------------------
>
>                 Key: TAPESTRY-1198
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-1198
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.1.1
>            Reporter: Norbert Sándor
>         Assigned To: Jesse Kuhnert
>             Fix For: 4.1.2
>
>         Attachments: Checkbox.patch
>
>
> I have a Checkbox component which has a custom validator. The validator requires the checkbox to be in checked state under certain circumstances.
> My problem is the following:
> 1. the checkbox is checked
> 2. the user unchecks it and submits the form
> 3. after the resulting page is rendered, the validation message is rendered as expected BUT the checkbox will be checked!
> The cause of the problem is that Checkbox doesn't record the newly submitted value in the validation delegate.
> For example TextField does this task indirectly by calling TranslatedFieldSupport.parse(), and the recorded value is read indirectly by TranslatedFieldSupport.format().
> Proposed solution: call the delegate's getFieldInputValue() and recordFieldInputValue() methods.
> Regards:
> Norbi

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org