You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:04:58 UTC
[GitHub] [flink] dianfu opened a new pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
dianfu opened a new pull request #13746:
URL: https://github.com/apache/flink/pull/13746
## What is the purpose of the change
*This pull request fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time*
## Brief change log
- *Fix rule PythonCalcExpandProjectRule*
## Verifying this change
This change added tests and can be verified as follows:
- *Added tests testPythonFunctionMixedWithJavaFunctionInWhereClause*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu merged pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #13746:
URL: https://github.com/apache/flink/pull/13746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
}, {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136",
"triggerID" : "714852312",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
}, {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136",
"triggerID" : "714852312",
"triggerType" : "MANUAL"
}, {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "714852312",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714852312
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714953187
@HuangXingBo Thanks a lot for the review. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714447981
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9becc81983d757b76614749a96a14a94f14aa7d6 (Thu Oct 22 12:07:14 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13746: [FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13746:
URL: https://github.com/apache/flink/pull/13746#issuecomment-714469108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"triggerType" : "PUSH"
}, {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136",
"triggerID" : "714852312",
"triggerType" : "MANUAL"
}, {
"hash" : "9becc81983d757b76614749a96a14a94f14aa7d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105",
"triggerID" : "714852312",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9becc81983d757b76614749a96a14a94f14aa7d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8136) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org