You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/05 18:40:10 UTC

[GitHub] [maven-deploy-plugin] plotters opened a new pull request, #21: [doc] improve site documentation deploy-ssh-external example

plotters opened a new pull request, #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MPH-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097168005

   @plotters I hope you have environment to test it ... I don't have such 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097168006

   @plotters I hope you have environment to test it ... I don't have such 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r843179383


##########
src/site/apt/examples/deploy-ssh-external.apt:
##########
@@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command
 
 +----+
 
- If you are deploying from Unix or have Cygwin installed you won't need to any additional configuration in your <<<settings.xml>>>
- file as everything will be taken from the environment. But if you are on Windows and are using something like <<<plink>>> then
- you will need something like the following:
+ If you are deploying from Linux/Unix or have Cygwin installed you only need to add the location of your PEM based private key in your <<<settings.xml>>>
+ 
++----+
+
+<settings>
+  ...
+  <servers>
+    <server>
+      <id>production-server</id>

Review Comment:
   `id` should be the same as in `distributionManagement`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] plotters commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
plotters commented on code in PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r848786754


##########
src/site/apt/examples/deploy-ssh-external.apt:
##########
@@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command
 
 +----+
 
- If you are deploying from Unix or have Cygwin installed you won't need to any additional configuration in your <<<settings.xml>>>
- file as everything will be taken from the environment. But if you are on Windows and are using something like <<<plink>>> then
- you will need something like the following:
+ If you are deploying from Linux/Unix or have Cygwin installed you only need to add the location of your PEM based private key in your <<<settings.xml>>>
+ 
++----+
+
+<settings>
+  ...
+  <servers>
+    <server>
+      <id>production-server</id>

Review Comment:
   @slawekjaranowski can this be merged now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] plotters commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
plotters commented on code in PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r843733793


##########
src/site/apt/examples/deploy-ssh-external.apt:
##########
@@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command
 
 +----+
 
- If you are deploying from Unix or have Cygwin installed you won't need to any additional configuration in your <<<settings.xml>>>
- file as everything will be taken from the environment. But if you are on Windows and are using something like <<<plink>>> then
- you will need something like the following:
+ If you are deploying from Linux/Unix or have Cygwin installed you only need to add the location of your PEM based private key in your <<<settings.xml>>>
+ 
++----+
+
+<settings>
+  ...
+  <servers>
+    <server>
+      <id>production-server</id>

Review Comment:
   thanks, consistency is improved now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #21:
URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097175393

   I'd say that this I'd partially wrong because `scp(1)` will find the private key automatically if there is one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-deploy-plugin] plotters closed pull request #21: [doc] improve site documentation deploy-ssh-external example

Posted by GitBox <gi...@apache.org>.
plotters closed pull request #21: [doc] improve site documentation deploy-ssh-external example
URL: https://github.com/apache/maven-deploy-plugin/pull/21


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org