You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2019/01/09 14:43:22 UTC
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12199
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
IMPALA-8043: Fix BE test failures related to SystemV timezones.
This is a fix for the following issue:
1. Some BE tests (e.g. ExprTest.TimestampFunctions) use the system's
local timezone but run against a test timezone db (instead of the
system's timezone db).
2. On some Linux installations /usr/share/zoneinfo contains symlinks
to files in the /usr/share/zoneifo/SystemV directory
(e.g /usr/share/zoneinfo/America/Los_Angeles is a symlink to
../SystemV/PST8PDT).
3. The 'SystemV' directory is not part of the test timezone db, since
it is obsolete and excluded by default.
Consequently, if the system's local timezone is set to
America/Los_Angeles, BE tests won't find the corresponding timezone
file in the test timezone db. BE tests will default to UTC, which will
break some of them.
This change sets local timezone explicitly for failing BE tests, so
they don't depend on the system's local timezone.
It also adds 'SystemV' directory to the test timezone db to avoid
similar issues in the future.
Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
---
M be/src/exprs/expr-test.cc
M testdata/data/timezoneverification.csv
M testdata/tzdb/2017c.zip
3 files changed, 45 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/12199/1
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 13:06:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG@28
PS1, Line 28: It also adds 'SystemV' directory to the test timezone db to avoid
: similar issues in the future.
> I would generally prefer to set local tz explicitly in every test to avoid
I think it is best to add SystemV to the tz db.
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc@6585
PS1, Line 6585: EXPECT_BETWEEN(unix_start_time, unix_timestamp_result,
: static_cast<int64_t>(mktime(&after)));
> I think that this test can fail during Autumn DST change. This failure is e
Done. Changed the tz (here and elsewhere in the test) to "America/Anguilla" which doesn't observe DST.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 11:46:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
IMPALA-8043: Fix BE test failures related to SystemV timezones.
This is a fix for the following issue:
1. Some BE tests (e.g. ExprTest.TimestampFunctions) use the system's
local timezone but run against a test timezone db (instead of the
system's timezone db).
2. On some Linux installations /usr/share/zoneinfo contains symlinks
to files in the /usr/share/zoneifo/SystemV directory
(e.g /usr/share/zoneinfo/America/Los_Angeles is a symlink to
../SystemV/PST8PDT).
3. The 'SystemV' directory is not part of the test timezone db, since
it is obsolete and excluded by default.
Consequently, if the system's local timezone is set to
America/Los_Angeles, BE tests won't find the corresponding timezone
file in the test timezone db. BE tests will default to UTC, which will
break some of them.
This change sets local timezone explicitly for failing BE tests, so
they don't depend on the system's local timezone.
It also adds 'SystemV' directory to the test timezone db to avoid
similar issues in the future.
Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Reviewed-on: http://gerrit.cloudera.org:8080/12199
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M testdata/data/timezoneverification.csv
M testdata/tzdb/2017c.zip
3 files changed, 51 insertions(+), 24 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG@28
PS1, Line 28: It also adds 'SystemV' directory to the test timezone db to avoid
: similar issues in the future.
I would generally prefer to set local tz explicitly in every test to avoid OS/timezone specific issues, but I am ok with adding SystemV if you think that it will save us from trouble in the future.
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc@6585
PS1, Line 6585: EXPECT_BETWEEN(unix_start_time, unix_timestamp_result,
: static_cast<int64_t>(mktime(&after)));
I think that this test can fail during Autumn DST change. This failure is extremely unlikely, but it could be avoided easily by using a timezone without DST.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 14:09:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3639/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 13:06:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
IMPALA-8043: Fix BE test failures related to SystemV timezones.
This is a fix for the following issue:
1. Some BE tests (e.g. ExprTest.TimestampFunctions) use the system's
local timezone but run against a test timezone db (instead of the
system's timezone db).
2. On some Linux installations /usr/share/zoneinfo contains symlinks
to files in the /usr/share/zoneifo/SystemV directory
(e.g /usr/share/zoneinfo/America/Los_Angeles is a symlink to
../SystemV/PST8PDT).
3. The 'SystemV' directory is not part of the test timezone db, since
it is obsolete and excluded by default.
Consequently, if the system's local timezone is set to
America/Los_Angeles, BE tests won't find the corresponding timezone
file in the test timezone db. BE tests will default to UTC, which will
break some of them.
This change sets local timezone explicitly for failing BE tests, so
they don't depend on the system's local timezone.
It also adds 'SystemV' directory to the test timezone db to avoid
similar issues in the future.
Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
---
M be/src/exprs/expr-test.cc
M testdata/data/timezoneverification.csv
M testdata/tzdb/2017c.zip
3 files changed, 51 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/12199/3
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc@6585
PS1, Line 6585: EXPECT_BETWEEN(unix_start_time, unix_timestamp_result,
: static_cast<int64_t>(mktime(&after)));
> Can you move this to a constant like TEST_TIMEZONE and add a comment about
Done
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 11:37:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
IMPALA-8043: Fix BE test failures related to SystemV timezones.
This is a fix for the following issue:
1. Some BE tests (e.g. ExprTest.TimestampFunctions) use the system's
local timezone but run against a test timezone db (instead of the
system's timezone db).
2. On some Linux installations /usr/share/zoneinfo contains symlinks
to files in the /usr/share/zoneifo/SystemV directory
(e.g /usr/share/zoneinfo/America/Los_Angeles is a symlink to
../SystemV/PST8PDT).
3. The 'SystemV' directory is not part of the test timezone db, since
it is obsolete and excluded by default.
Consequently, if the system's local timezone is set to
America/Los_Angeles, BE tests won't find the corresponding timezone
file in the test timezone db. BE tests will default to UTC, which will
break some of them.
This change sets local timezone explicitly for failing BE tests, so
they don't depend on the system's local timezone.
It also adds 'SystemV' directory to the test timezone db to avoid
similar issues in the future.
Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
---
M be/src/exprs/expr-test.cc
M testdata/data/timezoneverification.csv
M testdata/tzdb/2017c.zip
3 files changed, 47 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/12199/2
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/1750/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 15:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1785/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 12:55:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 3: Code-Review+2
Thanks for the changes!
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 12:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 17:04:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc@6585
PS1, Line 6585: EXPECT_BETWEEN(unix_start_time, unix_timestamp_result,
: static_cast<int64_t>(mktime(&after)));
> Done. Changed the tz (here and elsewhere in the test) to "America/Anguilla"
Can you move this to a constant like TEST_TIMEZONE and add a comment about the reason for choosing this timezone?
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 16:37:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1787/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 12:19:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1764/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681
Gerrit-Change-Number: 12199
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 09:57:44 +0000
Gerrit-HasComments: No