You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by vo...@apache.org on 2020/05/17 08:57:09 UTC

[fineract] branch develop updated (cbc274f -> 7a98ad8)

This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.


    from cbc274f  remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938)
     new 904da67  Remove un-used "Send messages to Email gateway" Job (FINERACT-952)
     new 7a98ad8  add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/fineract/integrationtests/SchedulerJobsTest.java     | 6 ++++++
 .../org/apache/fineract/infrastructure/jobs/service/JobName.java    | 1 -
 2 files changed, 6 insertions(+), 1 deletion(-)


[fineract] 01/02: Remove un-used "Send messages to Email gateway" Job (FINERACT-952)

Posted by vo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit 904da67bbdd33d258d5bab33dddb8ffc59dbaf56
Author: Michael Vorburger <mi...@vorburger.ch>
AuthorDate: Fri May 8 23:54:13 2020 +0200

    Remove un-used "Send messages to Email gateway" Job (FINERACT-952)
---
 .../java/org/apache/fineract/infrastructure/jobs/service/JobName.java    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java
index cebba45..97d9b14 100755
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java
@@ -47,7 +47,6 @@ public enum JobName {
     SEND_MESSAGES_TO_SMS_GATEWAY("Send Messages to SMS Gateway"),
     GET_DELIVERY_REPORTS_FROM_SMS_GATEWAY("Get Delivery Reports from SMS Gateway"),
     GENERATE_ADHOCCLIENT_SCEHDULE("Generate AdhocClient Schedule"),
-    SEND_MESSAGES_TO_EMAIL_GATEWAY("Send messages to Email gateway"),
     UPDATE_EMAIL_OUTBOUND_WITH_CAMPAIGN_MESSAGE("Update Email Outbound with campaign message"),
     EXECUTE_EMAIL("Execute Email"),
     UPDATE_TRAIL_BALANCE_DETAILS("Update Trial Balance Details");


[fineract] 02/02: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)

Posted by vo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit 7a98ad8d07ae1ff8b3c88722e1bf51a2b3adb1a3
Author: Michael Vorburger <mi...@vorburger.ch>
AuthorDate: Tue May 5 11:37:31 2020 +0200

    add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
    
    This would catch problems such as the integration tests running "too
    early" (before Flyway has fully initialized the database), which I have
    a suspicion could be one of (many) causes of the unstable scheduler
    tests, notably because of the IllegalArgumentException at
    SchedulerJobsTest.java:90 in https://github.com/apache/fineract/pull/817
---
 .../org/apache/fineract/integrationtests/SchedulerJobsTest.java     | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
index 2118152..f256047 100644
--- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
+++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
@@ -98,6 +98,12 @@ public class SchedulerJobsTest {
     }
 
     @Test
+    public void testNumberOfJobs() {
+        List<Integer> jobIds = schedulerJobHelper.getAllSchedulerJobIds();
+        assertEquals("Number of jobs in database and code do not match: " + jobIds, JobName.values().length, jobIds.size());
+    }
+
+    @Test
     public void testFlippingJobsActiveStatus() throws InterruptedException {
         // Stop the Scheduler while we test flapping jobs' active on/off, to avoid side
         // effects