You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 08:17:54 UTC

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4250: sched/wqueue: added debug option to tag and print worker name

a-lunev commented on a change in pull request #4250:
URL: https://github.com/apache/incubator-nuttx/pull/4250#discussion_r678930304



##########
File path: sched/wqueue/kwork_thread.c
##########
@@ -161,7 +170,15 @@ static int work_thread(int argc, FAR char *argv[])
            */
 
           leave_critical_section(flags);
+
+#ifdef CONFIG_WQUEUE_TAG_WORKER_NAME
+          sinfo("WORKER %s started\n", name_tag);
+#endif
           CALL_WORKER(worker, arg);

Review comment:
       Printing worker name is useful if the full debug log is analyzed what was happening, to analyze how all workers alternate to each other (the whole picture). If just worker addresses printed, it would be necessary to translate each address occurrences using System.map or addr2line, thus the full log not easily readable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org