You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/12/10 12:47:30 UTC
[GitHub] [couchdb] willholley opened a new pull request #2351: Fix timeout
case clause in fabric_db_info
willholley opened a new pull request #2351: Fix timeout case clause in fabric_db_info
URL: https://github.com/apache/couchdb/pull/2351
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
Unlike most other fabric_db_* message handlers, the accumulator
for fabric_db_info has 3 terms. When a rexi timeout occurs, it
returns `{timeout, Accumulator}`; the case clause handling this
needs to expect 3 terms in the Accumulator instead of 2.
## Testing recommendations
I can't see a good precedent for testing this but I'm happy to add a test if somebody can point me to an example.
## Related Issues or Pull Requests
Fixes #2350
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services