You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "vhogberg (via GitHub)" <gi...@apache.org> on 2026/08/13 12:58:46 UTC
[PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
vhogberg opened a new pull request, #43112:
URL: https://github.com/apache/superset/pull/43112
### SUMMARY
The shared 20px default legend margin is not enough for funnel charts. A top/bottom margin will make the chart overlap with the legend, see the image below. So you'd have to bump legend margin by hand on every new chart.
Funnel now defaults horizontal legends to 40px. An explicitly set legend margin still wins, and left/right legends are unchanged.
Added test to `superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="959" height="660" alt="image" src="https://github.com/user-attachments/assets/9b53a000-0d20-49f4-8dff-0fc04ba21ea5" />
-->
<img width="959" height="649" alt="image" src="https://github.com/user-attachments/assets/0ea53486-d724-4319-9198-7987c91a1630" />
### TESTING INSTRUCTIONS
1. Create a new Funnel chart with a few groupby values and leave all customize
options at their defaults.
2. Verify the top legend no longer overlaps the top of the funnel.
3. Set "Legend Margin" explicitly and see that the value is still respected.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43112:
URL: https://github.com/apache/superset/pull/43112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5280733013
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "vhogberg (via GitHub)" <gi...@apache.org>.
vhogberg commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3955214036
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -244,11 +247,19 @@ export default function transformProps(
if (!legendSort) return 0;
return legendSort === 'asc' ? a.localeCompare(b) : b.localeCompare(a);
});
+ const isHorizontalLegend = [
+ LegendOrientation.Top,
+ LegendOrientation.Bottom,
+ ].includes(legendOrientation);
+ const resolvedLegendMargin =
Review Comment:
pinging @sadpandajoe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3775574004
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -50,10 +50,13 @@ import { resolveLegendLayout } from '../utils/legendLayout';
import { defaultGrid } from '../defaults';
import { DEFAULT_LEGEND_FORM_DATA, OpacityEnum } from '../constants';
import { getDefaultTooltip } from '../utils/tooltip';
-import { Refs } from '../types';
+import { LegendOrientation, Refs } from '../types';
const percentFormatter = getNumberFormatter(NumberFormats.PERCENT_2_POINT);
+// funnel charts need a taller default height than the regular default of 20.
+const DEFAULT_HORIZONTAL_LEGEND_MARGIN = 40;
Review Comment:
**Suggestion:** The comment says this constant provides a taller default height, but the value controls legend margin/padding rather than chart height. Update the comment to describe the legend margin so future changes do not confuse the two dimensions. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor π§Ή</summary>
```mdx
- β οΈ Comment may confuse future maintainers about margin semantics.
- β οΈ Legend spacing still follows the intended 40px calculation.
- β οΈ No user-facing Funnel functionality is affected.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=638ffa410b2e43a9a922eaa02e1978ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=638ffa410b2e43a9a922eaa02e1978ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
**Line:** 57:58
**Comment:**
*Comment Mismatch: The comment says this constant provides a taller default height, but the value controls legend margin/padding rather than chart height. Update the comment to describe the legend margin so future changes do not confuse the two dimensions.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43112&comment_hash=bec03e554026046b9c1f95d54cc66a3f53cd0fc20d0f59835509d8de9a2175df&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43112&comment_hash=bec03e554026046b9c1f95d54cc66a3f53cd0fc20d0f59835509d8de9a2175df&reaction=dislike'>π</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5283276444
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5290126906
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | 6532cc6b8cd3c2637179468f41835934bf36e62c |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a7eb1992e0d6c0009a2de86 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-43112--superset-docs-preview.netlify.app](https://deploy-preview-43112--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3SWiA4o_sBnFFuUBCohkmiMf5fthnshlzPlCxaADlxB2Y5mH-7eVxGOKvLOQorYY42XSlj2IO0S53g-K7VtcGI3WDuyJrNprS2OxLOB7wc) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43112--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3819566119
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -244,11 +247,19 @@ export default function transformProps(
if (!legendSort) return 0;
return legendSort === 'asc' ? a.localeCompare(b) : b.localeCompare(a);
});
+ const isHorizontalLegend = [
+ LegendOrientation.Top,
+ LegendOrientation.Bottom,
+ ].includes(legendOrientation);
+ const resolvedLegendMargin =
Review Comment:
For a wrapped horizontal List legend, this supplies `40` as `currentMargin`, but the shared layout calculation still derives its multi-row requirement from the regular 20px default. Two rows therefore resolve to `max(40, 20 + 24) = 44`, rather than reserving the 40px base plus another row, so the additional row can still overlap the funnel. Could the chart-specific base be made available to that calculation and covered with a wrapped List-legend case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5281093902
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43112?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.67%. Comparing base ([`5936158`](https://app.codecov.io/gh/apache/superset/commit/59361581cdfb1583e60ccbdae77f71d4ead71216?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3cb7c74`](https://app.codecov.io/gh/apache/superset/commit/3cb7c74f4db453680204ea15305b94026d1e0de4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43112 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 2866 2866
Lines 162798 162803 +5
Branches 37507 37510 +3
=======================================
+ Hits 108542 108548 +6
+ Misses 52133 52132 -1
Partials 2123 2123
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.69% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43112?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "vhogberg (via GitHub)" <gi...@apache.org>.
vhogberg commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3819716743
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -244,11 +247,19 @@ export default function transformProps(
if (!legendSort) return 0;
return legendSort === 'asc' ? a.localeCompare(b) : b.localeCompare(a);
});
+ const isHorizontalLegend = [
+ LegendOrientation.Top,
+ LegendOrientation.Bottom,
+ ].includes(legendOrientation);
+ const resolvedLegendMargin =
Review Comment:
Funnel has no legend type control, so it's always scroll and not list, which shows a pager arrow instead of wrapping to another row. Let me know if you'd still prefer another implementation though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3777587556
##########
superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts:
##########
@@ -73,13 +74,25 @@ describe('Funnel transformProps', () => {
);
});
- test('does not apply a text border to segment labels', () => {
- // A white textBorder washes out the dark text on light-colored segments.
- const result = transformProps(chartProps as EchartsFunnelChartProps);
- const { label } = (result.echartOptions.series as any)[0];
- expect(label.color).toBe(supersetTheme.colorText);
- expect(label.textBorderColor).toBeUndefined();
- expect(label.textBorderWidth).toBeUndefined();
+ test('should reserve extra space for a horizontal legend by default (40 instead of 20)', () => {
+ const { echartOptions } = transformProps(
+ chartProps as EchartsFunnelChartProps,
+ );
+ const series = echartOptions.series as FunnelSeriesOption[];
+ expect(series[0].top).toBe(40);
+ });
+
+ test('should respect an explicit legend margin', () => {
+ const props = new ChartProps({
+ formData: { ...formData, legendMargin: 80 },
+ width: 800,
+ height: 600,
+ queriesData,
+ theme: supersetTheme,
+ });
+ const { echartOptions } = transformProps(props as EchartsFunnelChartProps);
+ const series = echartOptions.series as FunnelSeriesOption[];
+ expect(series[0].top).toBe(80);
});
Review Comment:
The Funnel transformProps tests added for the new default legend margin only cover the Top orientation, even though the new logic also applies to Bottom. Also, the previously existing regression test asserting that segment labels donβt get a text border was removed; keeping that assertion helps prevent unrelated regressions while changing legend layout behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5291644121
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43112:
URL: https://github.com/apache/superset/pull/43112#issuecomment-5280795295
<!-- Bito Reply -->
The flagged issue is correct. The constant `DEFAULT_HORIZONTAL_LEGEND_MARGIN` is used to define the margin/padding for the legend when it is positioned horizontally, not the chart height itself. Updating the comment will improve clarity for future maintenance.
To resolve this, update the comment in `superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts` as follows:
```typescript
// funnel charts need a larger default legend margin than the regular default of 20.
const DEFAULT_HORIZONTAL_LEGEND_MARGIN = 40;
```
There are no other comments in this PR to address. Would you like me to perform any other checks?
**superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts**
```
// funnel charts need a larger default legend margin than the regular default of 20.
const DEFAULT_HORIZONTAL_LEGEND_MARGIN = 40;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(funnel): prevent horizontal legends from overlapping the chart by default [superset]
Posted by "vhogberg (via GitHub)" <gi...@apache.org>.
vhogberg commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3775596936
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -50,10 +50,13 @@ import { resolveLegendLayout } from '../utils/legendLayout';
import { defaultGrid } from '../defaults';
import { DEFAULT_LEGEND_FORM_DATA, OpacityEnum } from '../constants';
import { getDefaultTooltip } from '../utils/tooltip';
-import { Refs } from '../types';
+import { LegendOrientation, Refs } from '../types';
const percentFormatter = getNumberFormatter(NumberFormats.PERCENT_2_POINT);
+// funnel charts need a taller default height than the regular default of 20.
+const DEFAULT_HORIZONTAL_LEGEND_MARGIN = 40;
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org