You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by yx...@apache.org on 2024/07/06 10:26:33 UTC
(shardingsphere) branch master updated: Fix sonar issue (#31993)
This is an automated email from the ASF dual-hosted git repository.
yx9o pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 2cec7a22bcd Fix sonar issue (#31993)
2cec7a22bcd is described below
commit 2cec7a22bcd6e75b2f55085d48a7885a612612f2
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Jul 6 18:26:27 2024 +0800
Fix sonar issue (#31993)
* Refactor SQLStatementContextFactoryTest
* Fix sonar issue
* Refactor SQLStatementBinder
* Refactor SQLStatementBinder
---
.../infra/binder/statement/ddl/CursorStatementBinder.java | 2 +-
.../infra/binder/statement/dml/DeleteStatementBinder.java | 2 +-
.../infra/binder/statement/dml/InsertStatementBinder.java | 2 +-
.../infra/binder/statement/dml/MergeStatementBinder.java | 2 +-
.../infra/binder/statement/dml/SelectStatementBinder.java | 4 +---
.../infra/binder/statement/dml/UpdateStatementBinder.java | 2 +-
.../handler/distsql/ral/updatable/SetDistVariableExecutorTest.java | 3 +--
7 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/ddl/CursorStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/ddl/CursorStatementBinder.java
index 1f9e4f03628..d7441455693 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/ddl/CursorStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/ddl/CursorStatementBinder.java
@@ -28,8 +28,8 @@ import org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.CursorS
*/
public final class CursorStatementBinder implements SQLStatementBinder<CursorStatement> {
- @SneakyThrows
@Override
+ @SneakyThrows(ReflectiveOperationException.class)
public CursorStatement bind(final CursorStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName) {
CursorStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
result.setCursorName(sqlStatement.getCursorName());
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/DeleteStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/DeleteStatementBinder.java
index aa37281d6ad..7af85829f63 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/DeleteStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/DeleteStatementBinder.java
@@ -41,7 +41,7 @@ public final class DeleteStatementBinder implements SQLStatementBinder<DeleteSta
return bind(sqlStatement, metaData, currentDatabaseName, Collections.emptyMap());
}
- @SneakyThrows
+ @SneakyThrows(ReflectiveOperationException.class)
private DeleteStatement bind(final DeleteStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
DeleteStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementBinder.java
index 9a850848931..fb7e0d8c487 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementBinder.java
@@ -47,7 +47,7 @@ public final class InsertStatementBinder implements SQLStatementBinder<InsertSta
return bind(sqlStatement, metaData, currentDatabaseName, Collections.emptyMap());
}
- @SneakyThrows
+ @SneakyThrows(ReflectiveOperationException.class)
private InsertStatement bind(final InsertStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
InsertStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/MergeStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/MergeStatementBinder.java
index 21c446bf1e0..3366e6d701f 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/MergeStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/MergeStatementBinder.java
@@ -67,7 +67,7 @@ public final class MergeStatementBinder implements SQLStatementBinder<MergeState
return bind(sqlStatement, metaData, currentDatabaseName, Collections.emptyMap());
}
- @SneakyThrows
+ @SneakyThrows(ReflectiveOperationException.class)
private MergeStatement bind(final MergeStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
MergeStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementBinder.java
index 5be672e26d8..95be9609ba5 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementBinder.java
@@ -41,13 +41,12 @@ import java.util.Optional;
*/
public final class SelectStatementBinder implements SQLStatementBinder<SelectStatement> {
- @SneakyThrows
@Override
public SelectStatement bind(final SelectStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName) {
return bind(sqlStatement, metaData, currentDatabaseName, Collections.emptyMap(), Collections.emptyMap());
}
- @SneakyThrows
+ @SneakyThrows(ReflectiveOperationException.class)
private SelectStatement bind(final SelectStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> outerTableBinderContexts, final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
SelectStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
@@ -84,7 +83,6 @@ public final class SelectStatementBinder implements SQLStatementBinder<SelectSta
* @param externalTableBinderContexts external table binder contexts
* @return bounded correlate subquery select statement
*/
- @SneakyThrows
public SelectStatement bindCorrelateSubquery(final SelectStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> outerTableBinderContexts, final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
return bind(sqlStatement, metaData, currentDatabaseName, outerTableBinderContexts, externalTableBinderContexts);
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/UpdateStatementBinder.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/UpdateStatementBinder.java
index 3d6fb85d6c6..49e3614ebbe 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/UpdateStatementBinder.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/UpdateStatementBinder.java
@@ -42,7 +42,7 @@ public final class UpdateStatementBinder implements SQLStatementBinder<UpdateSta
return bind(sqlStatement, metaData, currentDatabaseName, Collections.emptyMap());
}
- @SneakyThrows
+ @SneakyThrows(ReflectiveOperationException.class)
private UpdateStatement bind(final UpdateStatement sqlStatement, final ShardingSphereMetaData metaData, final String currentDatabaseName,
final Map<String, TableSegmentBinderContext> externalTableBinderContexts) {
UpdateStatement result = sqlStatement.getClass().getDeclaredConstructor().newInstance();
diff --git a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
index 37c543c9cd6..5a00353c53f 100644
--- a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
+++ b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
@@ -108,10 +108,9 @@ class SetDistVariableExecutorTest {
private ContextManager mockContextManager() {
MetaDataPersistService metaDataPersistService = mock(MetaDataPersistService.class, RETURNS_DEEP_STUBS);
when(metaDataPersistService.getPropsService()).thenReturn(mock(PropertiesPersistService.class));
- ContextManager result = new ContextManager(MetaDataContextsFactory.create(metaDataPersistService, new ShardingSphereMetaData()),
+ return new ContextManager(MetaDataContextsFactory.create(metaDataPersistService, new ShardingSphereMetaData()),
new ComputeNodeInstanceContext(new ComputeNodeInstance(mock(InstanceMetaData.class)), mock(WorkerIdGenerator.class),
new ModeConfiguration("Standalone", null), mock(LockContext.class), new EventBusContext()),
mock(PersistRepository.class));
- return result;
}
}