You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2020/04/01 18:04:00 UTC

[jira] [Commented] (IMPALA-9571) Impala fails to start up due to exception from boost::filesystem::remove_all()

    [ https://issues.apache.org/jira/browse/IMPALA-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073049#comment-17073049 ] 

Joe McDonnell commented on IMPALA-9571:
---------------------------------------

We use boost 1.61, and in this version, boost marked this signature of filesystem::remove_all() as BOOST_NOEXCEPT:

[https://github.com/boostorg/filesystem/blob/boost-1.61.0/include/boost/filesystem/operations.hpp#L674]
{noformat}
  inline
  boost::uintmax_t remove_all(const path& p, system::error_code& ec) BOOST_NOEXCEPT
                                       {return detail::remove_all(p, &ec);}{noformat}
However, it still has the same bug described in IMPALA-2846, so the BOOST_NOEXCEPT tells the compiler that remove_all() can't throw exceptions when it definitely can. The compiler may think it can remove the try/catch.

Boost 1.57 didn't declare this signature of remove_all() as BOOST_NOEXCEPT.

There was a fix for the underlying issue in directory_iterator_constructor: [https://github.com/boostorg/filesystem/commit/4e4374336c640c2717f6a1b168406e11bdf7d6f1]

This will require either bumping boost version to 1.63 or applying a patch to 1.61 (either with the fix or removing the BOOST_NOEXCEPT).

> Impala fails to start up due to exception from boost::filesystem::remove_all()
> ------------------------------------------------------------------------------
>
>                 Key: IMPALA-9571
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9571
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Catalog
>            Reporter: Yongzhi Chen
>            Assignee: Joe McDonnell
>            Priority: Major
>
> In impala-asf-master-exhaustive-data-cache build, 
> custom_cluster.test_local_catalog.TestCompactCatalogUpdates.test_restart_catalogd test failed:
> Error Message
> test setup failure
> Stacktrace
> common/custom_cluster_test_suite.py:190: in setup_method
>     self._start_impala_cluster(cluster_args, **kwargs)
> common/custom_cluster_test_suite.py:307: in _start_impala_cluster
>     check_call(cmd + options, close_fds=True)
> /usr/lib64/python2.7/subprocess.py:542: in check_call
>     raise CalledProcessError(retcode, cmd)
> E   CalledProcessError: Command '['/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/bin/start-impala-cluster.py', '--state_store_args=--statestore_update_frequency_ms=50     --statestore_priority_update_frequency_ms=50     --statestore_heartbeat_frequency_ms=50', '--cluster_size=3', '--num_coordinators=3', '--log_dir=/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/logs/custom_cluster_tests', '--log_level=1', '--impalad_args=--use_local_catalog=true ', '--state_store_args=None ', '--catalogd_args=--catalog_topic_mode=minimal ', '--impalad_args=--default_query_options=']' returned non-zero exit status 1
> .....
> 11:08:37 MainThread: Error starting cluster
> Traceback (most recent call last):
>   File "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/bin/start-impala-cluster.py", line 770, in <module>
>     expected_cluster_size - expected_catalog_delays)
>   File "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_cluster.py", line 186, in wait_until_ready
>     early_abort_fn=check_processes_still_running)
>   File "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_service.py", line 267, in wait_for_num_known_live_backends
>     early_abort_fn()
>   File "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_cluster.py", line 178, in check_processes_still_running
>     assert len(self.impalads) >= expected_num_impalads
> AssertionError
> DEBUG:impala_cluster:Found 2 impalad/1 statestored/1 catalogd process(es)
> Details:
> https://master-02.jenkins.cloudera.com/job/impala-asf-master-exhaustive-data-cache/113/testReport/custom_cluster.test_local_catalog/TestCompactCatalogUpdates/test_restart_catalogd/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org