You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sunkai-cai (via GitHub)" <gi...@apache.org> on 2023/02/17 11:45:50 UTC
[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #24223: Add information when throws UnavailableDataSourceException
sunkai-cai opened a new pull request, #24223:
URL: https://github.com/apache/shardingsphere/pull/24223
Fixes #24152.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223#issuecomment-1434559525
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24223](https://codecov.io/gh/apache/shardingsphere/pull/24223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3bb39a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/18745612142dc006b4e0e83ae3708b45420ef14c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1874561) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head e3bb39a differs from pull request most recent head b77b2cc. Consider uploading reports for the commit b77b2cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #24223 +/- ##
============================================
- Coverage 49.99% 49.99% -0.01%
Complexity 1575 1575
============================================
Files 3255 3255
Lines 53430 53432 +2
Branches 9863 9863
============================================
Hits 26713 26713
- Misses 24355 24357 +2
Partials 2362 2362
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...infra/datasource/state/DataSourceStateManager.java](https://codecov.io/gh/apache/shardingsphere/pull/24223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3N0YXRlL0RhdGFTb3VyY2VTdGF0ZU1hbmFnZXIuamF2YQ==) | `11.62% <0.00%> (ø)` | |
| [...tate/exception/UnavailableDataSourceException.java](https://codecov.io/gh/apache/shardingsphere/pull/24223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3N0YXRlL2V4Y2VwdGlvbi9VbmF2YWlsYWJsZURhdGFTb3VyY2VFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223#discussion_r1115918671
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/datasource/state/exception/UnavailableDataSourceException.java:
##########
@@ -35,4 +35,8 @@ public final class UnavailableDataSourceException extends ShardingSphereServerEx
public UnavailableDataSourceException(final SQLException cause) {
super(ERROR_CATEGORY, ERROR_CODE, "Data source unavailable.", cause);
}
+
+ public UnavailableDataSourceException(final SQLException cause, final String databaseName) {
+ super(ERROR_CATEGORY, ERROR_CODE, String.format("Data source unavailable from `%s` .", databaseName), cause);
Review Comment:
Hi @sunkai-cai ,
Is there an extra space after `%s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai commented on a diff in pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "sunkai-cai (via GitHub)" <gi...@apache.org>.
sunkai-cai commented on code in PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223#discussion_r1116405586
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/datasource/state/exception/UnavailableDataSourceException.java:
##########
@@ -35,4 +35,8 @@ public final class UnavailableDataSourceException extends ShardingSphereServerEx
public UnavailableDataSourceException(final SQLException cause) {
super(ERROR_CATEGORY, ERROR_CODE, "Data source unavailable.", cause);
}
+
+ public UnavailableDataSourceException(final SQLException cause, final String databaseName) {
+ super(ERROR_CATEGORY, ERROR_CODE, String.format("Data source unavailable from `%s` .", databaseName), cause);
Review Comment:
oh, i remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223#issuecomment-1442752964
Thank you! @sunkai-cai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai commented on pull request #24223: Add information when throws UnavailableDataSourceException
Posted by "sunkai-cai (via GitHub)" <gi...@apache.org>.
sunkai-cai commented on PR #24223:
URL: https://github.com/apache/shardingsphere/pull/24223#issuecomment-1442753889
@RaigorJiang You are welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org