You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/13 11:29:43 UTC
[GitHub] [kafka] showuon opened a new pull request #9175: KAFKA-10340: Fix the old checkpoint data won't be removed after alter log dir
showuon opened a new pull request #9175:
URL: https://github.com/apache/kafka/pull/9175
In [KIP-113](https://cwiki.apache.org/confluence/display/KAFKA/KIP-113%3A+Support+replicas+movement+between+log+directories), we support replicas movement between log directories. But while the directory change, we forgot to remove the topicPartition offset data in old directory, which will cause there are 2 copies stayed in the logs for the altered topicPartition. And it'll LogCleaner gets stuck due to get the old topicPartition offset data. I added one more parameter `topicPartitionToBeRemoved` in `updateCheckpoints()` method. So, if the `update` parameter is `None`, we'll do the remove action to remove the `topicPartitionToBeRemoved` data in dir, otherwise, update the data as before.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-10340: Fix the old checkpoint data won't be removed after alter log dir
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9175:
URL: https://github.com/apache/kafka/pull/9175#issuecomment-673423404
@lindong28 @tombentley , could you help review this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #9175:
URL: https://github.com/apache/kafka/pull/9175#issuecomment-673423404
@showuon , could you help review this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9175:
URL: https://github.com/apache/kafka/pull/9175#issuecomment-673831587
close this PR since it links to the wrong jira ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9175:
URL: https://github.com/apache/kafka/pull/9175#issuecomment-673860247
@showuon hellp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon closed pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir
Posted by GitBox <gi...@apache.org>.
showuon closed pull request #9175:
URL: https://github.com/apache/kafka/pull/9175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org