Re: [I] Remove checkindex -exorcise [LUCENE-6344] [lucene]

["serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org>]

serhiy-bzhezytskyy commented on issue #7405:
URL: https://github.com/apache/lucene/issues/7405#issuecomment-5158644400

   Cross-linking this, since two open PRs touch `-exorcise` and nothing here points at them.
   
   #16474 makes `exorciseIndex` refuse instead of throwing `NullPointerException` when given the status of an index whose commit point could not be read — a Luke user gets that NPE today by pressing Repair. #16476 makes `CheckIndex` report which segment's `.si` was unreadable. The first stands regardless: an NPE out of a public API is worth fixing whether or not the option survives. The second only makes sense if repair is something worth improving, so it is at odds with what this issue proposes.
   
   @rmuir — this has had no comments since you filed it in 2015, so I cannot tell whether the position still holds or was never revisited. Asking because I have written code into the feature, not to reopen an argument.
   
   #10004 reached a related conclusion from a different direction: @jpountz declined a salvage patch there with *"I'd like to keep CheckIndex something that is rock solid"* and *"A separate stand-alone tool sounds good to me too"* — repair not belonging inside a diagnostic tool, rather than repair not being wanted. Neither issue references the other; the details are on #10004 rather than duplicated here.
   
   One thing that turned up while looking, relevant either way: `new CheckIndex(dir)` takes `IndexWriter.WRITE_LOCK_NAME` in its constructor (`CheckIndex.java:465`), so a tool named "check" needs exclusive write access in order to read an index. Whichever way this issue goes, that is part of the same knot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org