You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by canselcik <gi...@git.apache.org> on 2015/11/16 20:58:44 UTC
[GitHub] trafficserver pull request: Memory leak in Rule::socksParse(char*)...
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/340
Memory leak in Rule::socksParse(char*) if a token is missing the '=' sign
Memory is allocated at line 585 with `TokenList *m_tokenList = new TokenList()` but reference to it is lost when the function returns early due to a token not having the `=` sign.
@bgaff
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/canselcik/trafficserver genericParser-memleak-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit 06243e21b28bcc1e8e7c69ab8cd471b4157cfdfb
Author: Can Selcik <cs...@linkedin.com>
Date: 2015-11-16T19:55:48Z
Memory leak in Rule::socksParse(char*) when a token is missing the '=' sign
Memory is allocated at line 585 with `TokenList *m_tokenList = new TokenList()` but reference to it is lost when the function returns early due to a token not having the `=` sign.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Memory leak in Rule::socksParse(char*)...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Memory leak in Rule::socksParse(char*)...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/340#issuecomment-157165638
@canselcik thanks, I'll merge this after the summit today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---